-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-235: Enable kube api-server Caching for Log Collection #100794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-235: Enable kube api-server Caching for Log Collection #100794
Conversation
|
@theashiot: This pull request references OBSDOCS-235 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Thu Oct 30 08:06:45 - Prow CI generated the docs preview: |
|
@theashiot: This pull request references OBSDOCS-235 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
62f6557 to
56fded1
Compare
|
Thanks, @jcantrill for the review! I've made all the changes. best, |
|
/lgtm |
|
/lgtm |
|
Thanks, @jcantrill and @anpingli! best, |
|
@theashiot: This pull request references OBSDOCS-235 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gabriel-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe add comment block at the top that lists which assemblies include this module, but not sure that really matters any more...
56fded1 to
8fcb006
Compare
|
New changes are detected. LGTM label has been removed. |
|
Thanks, @gabriel-rh for the review! I've added the required comment block. best, |
|
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
c846f35
into
openshift:standalone-logging-docs-main
|
/cherrypick standalone-logging-docs-6.4 |
|
@briandooley: new pull request created: #101670 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 6.4
Issue: https://issues.redhat.com/browse/OBSDOCS-2354
Link to docs preview: https://100794--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html#configuring-pod-rollout-strategy_cluster-logging-collector
QE review:
Additional information: