Skip to content

Conversation

@theashiot
Copy link
Contributor

@theashiot theashiot commented Oct 19, 2025

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2025

@theashiot: This pull request references OBSDOCS-235 which is a valid jira issue.

In response to this:

Version(s): 6.4

Issue: https://issues.redhat.com/browse/OBSDOCS-2354

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 19, 2025

🤖 Thu Oct 30 08:06:45 - Prow CI generated the docs preview:

https://100794--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2025

@theashiot: This pull request references OBSDOCS-235 which is a valid jira issue.

In response to this:

Version(s): 6.4

Issue: https://issues.redhat.com/browse/OBSDOCS-2354

Link to docs preview: https://100794--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html#configuring-pod-rollout-strategy_cluster-logging-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theashiot
Copy link
Contributor Author

Thanks, @jcantrill for the review! I've made all the changes.

best,
ashwin

@jcantrill
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2025
@anpingli
Copy link

/lgtm

@theashiot
Copy link
Contributor Author

Thanks, @jcantrill and @anpingli!

best,
ashwin

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@theashiot: This pull request references OBSDOCS-235 which is a valid jira issue.

In response to this:

Version(s): 6.4

Issue: https://issues.redhat.com/browse/OBSDOCS-2354

Link to docs preview: https://100794--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/cluster-logging-collector.html#configuring-pod-rollout-strategy_cluster-logging-collector

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe add comment block at the top that lists which assemblies include this module, but not sure that really matters any more...

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

New changes are detected. LGTM label has been removed.

@theashiot
Copy link
Contributor Author

Thanks, @gabriel-rh for the review! I've added the required comment block.

best,
ashwin

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@briandooley briandooley merged commit c846f35 into openshift:standalone-logging-docs-main Nov 4, 2025
2 checks passed
@briandooley
Copy link
Contributor

/cherrypick standalone-logging-docs-6.4

@openshift-cherrypick-robot

@briandooley: new pull request created: #101670

In response to this:

/cherrypick standalone-logging-docs-6.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants