-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ROX-30965: Rename image signature policy field #101154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-30965: Rename image signature policy field #101154
Conversation
Note that only the first word is capitalized to match the name actually presented in the UI [1]. [1] https://github.com/stackrox/stackrox/blob/e8a7f4a5b80903d26e01317593b916888d1d11ae/ui/apps/platform/src/Containers/Policies/Wizard/Step3/policyCriteriaDescriptors.tsx#L360
|
@guzalv: This pull request references ROX-30965 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @guzalv. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
🤖 Tue Oct 28 15:27:32 - Prow CI generated the docs preview: |
|
@guzalv: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@guzalv: This pull request references ROX-30965 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@guzalv: This pull request references ROX-30965 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
LGTM |
Note that only the first word is capitalized to match the name actually presented in the UI [1].
[1] https://github.com/stackrox/stackrox/blob/e8a7f4a5b80903d26e01317593b916888d1d11ae/ui/apps/platform/src/Containers/Policies/Wizard/Step3/policyCriteriaDescriptors.tsx#L360
Version(s): 4.10.0
Issue: https://issues.redhat.com/browse/ROX-30965
Link to docs preview: https://101154--ocpdocs-pr.netlify.app/openshift-acs/latest/operating/manage_security_policies/security-policy-reference.html#reference-image-criteria_security-policy-reference
QE review: ACS does not have QE