From c637344fc14e4a715617b8494ec9ab146fd352d3 Mon Sep 17 00:00:00 2001 From: Prithviraj Patil <116709298+prithvipatil97@users.noreply.github.com> Date: Wed, 29 Oct 2025 17:16:44 +0530 Subject: [PATCH] Installation - Update installing-logging-operator-cli.adoc - Several commands are included within a single code block. Here is the documentation link: https://docs.redhat.com/en/documentation/red_hat_openshift_logging/6.3/html/installing_logging/installing-logging#installing-logging-operator-cli_installing-logging - As per the standard rule, using more than one command per code block is not recommended. - Please check Standard rule [2] for reference: [2] https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#single-command-per-code-block - When commands are bunched together, the copy to clipboard functionality might not break the lines up correctly. - Using a single command per code block makes it copy-and-paste friendly. - Hence, we need to mention 3 separate code blocks for above 3 commands. Here is the updated look of the documentation: ~~~ $ oc adm policy add-cluster-role-to-user logging-collector-logs-writer -z logging-collector -n openshift-logging ~~~ ~~~ $ oc adm policy add-cluster-role-to-user collect-application-logs -z logging-collector -n openshift-logging ~~~ ~~~ $ oc adm policy add-cluster-role-to-user collect-infrastructure-logs -z logging-collector -n openshift-logging ~~~ --- modules/installing-logging-operator-cli.adoc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/installing-logging-operator-cli.adoc b/modules/installing-logging-operator-cli.adoc index 9a596f4f99f3..6f8a7912a0f1 100644 --- a/modules/installing-logging-operator-cli.adoc +++ b/modules/installing-logging-operator-cli.adoc @@ -79,7 +79,15 @@ $ oc create sa logging-collector -n openshift-logging [source,terminal] ---- $ oc adm policy add-cluster-role-to-user logging-collector-logs-writer -z logging-collector -n openshift-logging +---- ++ +[source,terminal] +---- $ oc adm policy add-cluster-role-to-user collect-application-logs -z logging-collector -n openshift-logging +---- ++ +[source,terminal] +---- $ oc adm policy add-cluster-role-to-user collect-infrastructure-logs -z logging-collector -n openshift-logging ----