Skip to content

Conversation

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 18, 2025

@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_osa_note branch from fee2e0f to c48be10 Compare November 20, 2025 15:55
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2025
@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_osa_note branch 2 times, most recently from 8379aac to 6aec778 Compare November 21, 2025 09:57
@ashokpariya0
Copy link

Thanks @SNiemann15
Changes looks correct.
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2025

@ashokpariya0: changing LGTM is restricted to collaborators

In response to this:

Thanks @SNiemann15
Changes looks correct.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_osa_note branch 3 times, most recently from 3ef5044 to 4d153fa Compare November 24, 2025 09:14
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit, otherwise lgtm

[NOTE]
====
When running {VirtProductName} on {ibm-z-name} using an OSA card, be aware that the OSA card only forwards network traffic to devices that are registered with the OSA device. As a result, any traffic destined for unregistered devices is not forwarded.
When running {VirtProductName} on {ibm-z-name}, be aware that certain network interfaces such as OSA, RoCE, and HiperSockets only forward network traffic to devices that are registered with the respective interface. As a result, any traffic destined for unregistered devices is not forwarded. For more information, see link:https://www.ibm.com/docs/en/linux-on-systems?topic=choices-osa-interface-traffic-forwarding[OSA interface traffic forwarding] (IBM documentation).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When running {VirtProductName} on {ibm-z-name}, be aware that certain network interfaces such as OSA, RoCE, and HiperSockets only forward network traffic to devices that are registered with the respective interface. As a result, any traffic destined for unregistered devices is not forwarded. For more information, see link:https://www.ibm.com/docs/en/linux-on-systems?topic=choices-osa-interface-traffic-forwarding[OSA interface traffic forwarding] (IBM documentation).
When running {VirtProductName} on {ibm-z-name}, be aware that certain network interfaces, such as OSA, RoCE, and HiperSockets, only forward network traffic to devices that are registered with the respective interface. As a result, any traffic destined for unregistered devices is not forwarded. For more information, see link:https://www.ibm.com/docs/en/linux-on-systems?topic=choices-osa-interface-traffic-forwarding[OSA interface traffic forwarding] (IBM documentation).

@SNiemann15 SNiemann15 force-pushed the ocpvirt_ibmz_osa_note branch from e2c6e9e to 37c203c Compare November 26, 2025 09:34
@openshift-ci
Copy link

openshift-ci bot commented Nov 26, 2025

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abrennan89 abrennan89 added this to the Continuous Release milestone Nov 26, 2025
@abrennan89 abrennan89 merged commit 8ae85a9 into openshift:main Nov 26, 2025
2 checks passed
@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.19

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.20

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@abrennan89: #102663 failed to apply on top of branch "enterprise-4.19":

Applying: Extend OSA notes to Roce and Hipersockets
.git/rebase-apply/patch:34: trailing whitespace.
`spec.template.spec.networks.multus.networkName`:: Specifies the name of the network attachment definition. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/virt-attaching-vm-secondary-network-cli.adoc
M	modules/virt-attaching-vm-to-secondary-udn.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/virt-attaching-vm-to-secondary-udn.adoc
CONFLICT (content): Merge conflict in modules/virt-attaching-vm-to-secondary-udn.adoc
Auto-merging modules/virt-attaching-vm-secondary-network-cli.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Extend OSA notes to Roce and Hipersockets

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #103127

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #103128

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 CNV Label for all CNV PRs lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants