-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[CNV#72324] Extend OSA notes to Roce and Hipersockets #102663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fee2e0f to
c48be10
Compare
8379aac to
6aec778
Compare
|
Thanks @SNiemann15 |
|
@ashokpariya0: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3ef5044 to
4d153fa
Compare
sjhala-ccs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny nit, otherwise lgtm
| [NOTE] | ||
| ==== | ||
| When running {VirtProductName} on {ibm-z-name} using an OSA card, be aware that the OSA card only forwards network traffic to devices that are registered with the OSA device. As a result, any traffic destined for unregistered devices is not forwarded. | ||
| When running {VirtProductName} on {ibm-z-name}, be aware that certain network interfaces such as OSA, RoCE, and HiperSockets only forward network traffic to devices that are registered with the respective interface. As a result, any traffic destined for unregistered devices is not forwarded. For more information, see link:https://www.ibm.com/docs/en/linux-on-systems?topic=choices-osa-interface-traffic-forwarding[OSA interface traffic forwarding] (IBM documentation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| When running {VirtProductName} on {ibm-z-name}, be aware that certain network interfaces such as OSA, RoCE, and HiperSockets only forward network traffic to devices that are registered with the respective interface. As a result, any traffic destined for unregistered devices is not forwarded. For more information, see link:https://www.ibm.com/docs/en/linux-on-systems?topic=choices-osa-interface-traffic-forwarding[OSA interface traffic forwarding] (IBM documentation). | |
| When running {VirtProductName} on {ibm-z-name}, be aware that certain network interfaces, such as OSA, RoCE, and HiperSockets, only forward network traffic to devices that are registered with the respective interface. As a result, any traffic destined for unregistered devices is not forwarded. For more information, see link:https://www.ibm.com/docs/en/linux-on-systems?topic=choices-osa-interface-traffic-forwarding[OSA interface traffic forwarding] (IBM documentation). |
e2c6e9e to
37c203c
Compare
|
@SNiemann15: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
abrennan89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.21 |
|
@abrennan89: #102663 failed to apply on top of branch "enterprise-4.19": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@abrennan89: new pull request created: #103127 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@abrennan89: new pull request created: #103128 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.19+
Issue: https://issues.redhat.com/browse/CNV-72324
Link to docs preview:
https://102663--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-secondary-udn.html#virt-attaching-vm-to-secondary-udn_virt-connecting-vm-to-secondary-udn
https://102663--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-linux-bridge.html#virt-attaching-vm-secondary-network-cli_virt-connecting-vm-to-linux-bridge
QE review:
Additional information:
In preparation for dita I changed callouts to DLs according to this guidance also resolved further vale warnings: https://docs.google.com/document/d/1j78SA8Y-ZRlVATbVe6D8bdYj7mQzzhOJtGt1xH_3qa0/edit?tab=t.0#heading=h.vsfnqm21wp0r