Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1274083, added Configuring Node Resources section #1518

Merged
merged 1 commit into from Feb 22, 2016

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh added peer-review-in-progress Signifies that the peer review team is reviewing this PR branch/enterprise-3.0 branch/enterprise-3.1 labels Feb 1, 2016
@ahardin-rh ahardin-rh self-assigned this Feb 1, 2016
@ahardin-rh ahardin-rh added this to the Next Release milestone Feb 1, 2016
@ahardin-rh
Copy link
Contributor Author

@adellape, any first thoughts?

@@ -270,3 +270,26 @@ $ oadm manage-node <node1> <node2> \
Alternatively, instead of specifying specific node names (e.g., `_<node1>_
_<node2>_`), you can use the `--selector=_<node_selector>_` option to evacuate
pods on selected nodes.

== Configuring Node Resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unique anchor.

@ahardin-rh
Copy link
Contributor Author

@rjhowe completed my first pass at this. PTAL. Thanks!

[[configuring-node-resources]]
== Configuring Node Resources
You can configure node resources by adding kubelet arguments to the node
configuration file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my last comment on this spot got kinda messed up cuz I didn't wrap em in backticks. Basically we need to verify where in this file (e.g., what section/stanza, what parameter name) these should be set.

@rjhowe
Copy link

rjhowe commented Feb 12, 2016

@ahardin-rh we really should show how this will look in the node-config.yaml

Example:

....
kubeletArguments:
  max-pods
    - "40"
  resolv-conf
    - "/etc/resolv.conf"
  image-gc-high-threshold:
    - "90"
  image-gc-low-threshold:
    - "80"
...

Taking this even further we could reference how this would look in the ansible hosts file.

openshift_node_kubelet_args={'max-pods': ['40'], 'resolv-conf': ['/etc/resolv.conf'],  'image-gc-high-threshold': ['90'], 'image-gc-low-threshold': ['80']}

@ahardin-rh
Copy link
Contributor Author

@rjhowe @adellape Thanks! Made some edits.

@ahardin-rh
Copy link
Contributor Author

@rjhowe @adellape Good to go?

[[configuring-node-resources]]
== Configuring Node Resources
You can configure node resources by adding kubelet arguments to the node
configuration file (/etc/origin/node/node-config.yaml). Add the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark up the file name.

@adellape
Copy link
Contributor

@ahardin-rh Two minor nits, otherwise LGTM.

@ahardin-rh
Copy link
Contributor Author

@adellape Fixed. Thanks!

@ahardin-rh
Copy link
Contributor Author

@rjhowe further edits?

@ahardin-rh ahardin-rh removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 22, 2016
@ahardin-rh ahardin-rh changed the title [WIP] Bug 1274083, added Configuring Node Resources section Bug 1274083, added Configuring Node Resources section Feb 22, 2016
ahardin-rh added a commit that referenced this pull request Feb 22, 2016
Bug 1274083, added Configuring Node Resources section
@ahardin-rh ahardin-rh merged commit 57c8cd3 into openshift:master Feb 22, 2016
@ahardin-rh
Copy link
Contributor Author

OLD revhistory note:

(for Admin Guide --> Managing Nodes)

Added the link:../admin_guide/manage_nodes.html#configuring-node-resources[Configuring Node Resources] section.

(for Install/Config --> Advanced Install)

Added `*openshift_node_kubelet_args*` to the link:../install_config/install/advanced_install.html#configuring-ansible[Host Variables table].

@ahardin-rh ahardin-rh modified the milestones: Next Release, Published - Feb 29, 2016 Feb 29, 2016
@ahardin-rh ahardin-rh modified the milestone: Next Release Mar 9, 2016
@adellape
Copy link
Contributor

adellape commented Mar 9, 2016

This had some follow-up, see #1719 for new revhistory note for the kubelet args piece. For the Admin Guide piece, see next comment.

@adellape
Copy link
Contributor

adellape commented Mar 9, 2016

[rev_history]
|link:../admin_guide/manage_nodes.html[Managing Nodes]

|Added the link:../admin_guide/manage_nodes.html#configuring-node-resources[Configuring Node Resources] section.
%

@vikram-redhat vikram-redhat modified the milestones: Next Release, Published - 17 Mar, 2016 Mar 17, 2016
@ahardin-rh ahardin-rh deleted the node-resources branch November 9, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants