New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1274083, added Configuring Node Resources section #1518
Conversation
@adellape, any first thoughts? |
@@ -270,3 +270,26 @@ $ oadm manage-node <node1> <node2> \ | |||
Alternatively, instead of specifying specific node names (e.g., `_<node1>_ | |||
_<node2>_`), you can use the `--selector=_<node_selector>_` option to evacuate | |||
pods on selected nodes. | |||
|
|||
== Configuring Node Resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a unique anchor.
b993eec
to
7c7d69b
Compare
@rjhowe completed my first pass at this. PTAL. Thanks! |
[[configuring-node-resources]] | ||
== Configuring Node Resources | ||
You can configure node resources by adding kubelet arguments to the node | ||
configuration file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my last comment on this spot got kinda messed up cuz I didn't wrap em in backticks. Basically we need to verify where in this file (e.g., what section/stanza, what parameter name) these should be set.
@ahardin-rh we really should show how this will look in the node-config.yaml Example:
Taking this even further we could reference how this would look in the ansible hosts file.
|
7c7d69b
to
f317324
Compare
[[configuring-node-resources]] | ||
== Configuring Node Resources | ||
You can configure node resources by adding kubelet arguments to the node | ||
configuration file (/etc/origin/node/node-config.yaml). Add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark up the file name.
@ahardin-rh Two minor nits, otherwise LGTM. |
f317324
to
7959a83
Compare
@adellape Fixed. Thanks! |
@rjhowe further edits? |
Bug 1274083, added Configuring Node Resources section
OLD revhistory note: (for Admin Guide --> Managing Nodes)
(for Install/Config --> Advanced Install)
|
This had some follow-up, see #1719 for new revhistory note for the kubelet args piece. For the Admin Guide piece, see next comment. |
[rev_history] |Added the link:../admin_guide/manage_nodes.html#configuring-node-resources[Configuring Node Resources] section. |
https://bugzilla.redhat.com/show_bug.cgi?id=1274083
@adellape PTAL at this first draft