Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docker login using service account tokens #2014

Merged
merged 1 commit into from Jul 5, 2016
Merged

add docker login using service account tokens #2014

merged 1 commit into from Jul 5, 2016

Conversation

aweiteka
Copy link

@aweiteka aweiteka commented May 5, 2016

This addresses a common question since docker login -p $(oc whoami -t) -u unused -e unused REGISTRY:5000 expires every 24 hours by default. I suspect we should incorporate some of this as a separate PR for users who do not want or cannot use openshift to perform docker build.

@aweiteka
Copy link
Author

aweiteka commented May 5, 2016

cc @v1k0d3n

@aweiteka
Copy link
Author

aweiteka commented May 5, 2016

cc @brianwcook

@v1k0d3n
Copy link

v1k0d3n commented May 5, 2016

i fully support this awesome PR! :)

@aweiteka aweiteka mentioned this pull request May 5, 2016
Merged
ahardin-rh
ahardin-rh reviewed Jul 1, 2016
View reviewed changes
registry_quickstart/administrators/system_configuration.adoc
@@ -128,6 +131,16 @@ Restart the origin service to update the running configuration.
$ sudo docker restart origin
----

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an anchor right before the heading to ensure that the link above works properly:

[[using-service-account-tokens-for-authentication]]
== Using Service Account Tokens for Authentication

@ahardin-rh ahardin-rh self-assigned this Jul 1, 2016
@ahardin-rh ahardin-rh added this to the Next Release milestone Jul 1, 2016
@aweiteka
Copy link
Author

aweiteka commented Jul 5, 2016

@ahardin-rh updated, rebased, commits squashed. Thanks!

@ahardin-rh ahardin-rh merged commit e4d2798 into openshift:master Jul 5, 2016
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../registry_quickstart/administrators/system_configuration.adoc#registry-quickstart-administrators-system-configuration[Getting Started with System Configuration for Administrators]
|Added a new xref:../registry_quickstart/administrators/system_configuration.adoc#using-service-account-tokens-for-authentication[Using Service Account Tokens for Authentication] section.
%
|xref:../registry_quickstart/developers.adoc#registry-quickstart-developers[Getting Started for Developers]
|Added a new xref:../registry_quickstart/developers.adoc#using-service-account-tokens-for-docker-login[Using Service Account Tokens for Docker Login] section.
%

@ahardin-rh ahardin-rh mentioned this pull request Jul 5, 2016
Merged
@adellape adellape modified the milestones: Next Release, Staging Jul 11, 2016
@adellape adellape modified the milestones: Staging, Staging (Picked) Jul 12, 2016
@adellape adellape modified the milestones: Staging, Staging (Picked), Published - 7/14/16 - 7/21/16 Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ahardin-rh ahardin-rh

Labels
branch/enterprise-3.1 branch/enterprise-3.2 branch/online
Projects
None yet
Milestone
Published - 07/14/16 - 07/21/16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aweiteka @v1k0d3n @ahardin-rh @adellape