Skip to content

Conversation

@neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Apr 6, 2020

This pr addresses

OSSMDOC-49
OSSMDOC-44
OSSMDOC-39
OSSMDOC-56
OSSMDOC-57

and should be cherrypicked to the 4.3 and 4.4 branch.

@neal-timpe
Copy link
Contributor Author

@dgm for https://issues.redhat.com/browse/OSSMDOC-49, I've written a sentence in ossm-vs-istio.adoc, but it feels light. Can you give me more details about what that means?

@dmitri-d for https://issues.redhat.com/browse/OSSMDOC-44 same question.

@openshift-docs-preview-bot

The preview will be available shortly at:

@dgm
Copy link

dgm commented Apr 7, 2020

@neal-timpe I think you tagged the wrong person? I don't have any idea what this is. :D

@neal-timpe neal-timpe requested a review from brian-avery April 7, 2020 15:21
Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nit

@neal-timpe neal-timpe requested a review from brian-avery April 7, 2020 19:58
@neal-timpe neal-timpe requested review from JStickler and tvieira April 7, 2020 21:19
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions, but nothing major.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Cluster administrators can refer to the {product-title} documentation for instructions on how to enable subdomains."
Have you found the docs yet? It would be nice if we could provide the link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'm working on it.

Copy link

@tvieira tvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neal-timpe neal-timpe requested a review from gbaufake April 8, 2020 14:01
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbaufake Here is the added delete command. I think I just need your review here. If you like you can review this whole PR, but if you don't have time, this is what I tagged you for.

@neal-timpe neal-timpe merged commit 70be0ce into openshift:master Apr 8, 2020
@neal-timpe
Copy link
Contributor Author

/cherry-pick enterprise-4.3

@openshift-cherrypick-robot

@neal-timpe: new pull request created: #21041

In response to this:

/cherry-pick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe
Copy link
Contributor Author

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot

@neal-timpe: new pull request created: #21042

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ior branch April 15, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants