-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Ior #20952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ior #20952
Conversation
|
@dgm for https://issues.redhat.com/browse/OSSMDOC-49, I've written a sentence in ossm-vs-istio.adoc, but it feels light. Can you give me more details about what that means? @dmitri-d for https://issues.redhat.com/browse/OSSMDOC-44 same question. |
|
The preview will be available shortly at: |
|
@neal-timpe I think you tagged the wrong person? I don't have any idea what this is. :D |
jwendell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a nit
JStickler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions, but nothing major.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Cluster administrators can refer to the {product-title} documentation for instructions on how to enable subdomains."
Have you found the docs yet? It would be nice if we could provide the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I'm working on it.
tvieira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modules/ossm-operatorhub-remove.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbaufake Here is the added delete command. I think I just need your review here. If you like you can review this whole PR, but if you don't have time, this is what I tagged you for.
|
/cherry-pick enterprise-4.3 |
|
@neal-timpe: new pull request created: #21041 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.4 |
|
@neal-timpe: new pull request created: #21042 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This pr addresses
OSSMDOC-49
OSSMDOC-44
OSSMDOC-39
OSSMDOC-56
OSSMDOC-57
and should be cherrypicked to the 4.3 and 4.4 branch.