CNV bz1845198 hugepages #23705
CNV bz1845198 hugepages #23705
Conversation
openshift-ci-robot
added
the
size/M
|
The preview will be available shortly at: |
|
|
||
| The memory request must be divisible by the page size. For example, you can not request `500Mi` memory with a page size of `1Gi`. | ||
|
|
||
| [NOTE] |
There was a problem hiding this comment.
@kbidarkar
@stu-gott provided some draft text that hopefully clarifies the issue in BZ#1822875. If this is acceptable then I can merge this and put a link to the doc in the two bugs
|
LGTM |
aburdenthehand
force-pushed
the
cnv-bz1845198-hugepages
branch
from
3bc193f
to
74e72e4
Compare
modules/what-huge-pages-do.adoc
Outdated
| endif::ocp-hugepages[] | ||
|
|
||
| ifdef::virt-hugepages[] | ||
| In {VirtProductName}, virtual machines can be configued to consume pre-allocated |
| The memory layouts of the host and the guest OS are unrelated. | ||
| Hugepages requested in the virtual machine manifest apply to QEMU. | ||
| Hugepages inside the guest can only be configured based on the amount of available memory of the virtual machine instance. |
There was a problem hiding this comment.
Nit: I'd prefer if this last sentence were in the active voice.
There was a problem hiding this comment.
It might be my preference talking but I find this easier to understand than the alternative:
"You can only configure huge pages inside the guest based on the amount of available memory of the virtual machine instance."
| .Prerequisites | ||
|
|
||
| * Nodes must have pre-allocated huge pages configured. |
There was a problem hiding this comment.
Do we need to repeat the prereq here, since it's in the assembly itself? (It is a good reminder, so I'm not really mad at it.)
There was a problem hiding this comment.
Yeah, in the built doc the assembly prereq is quite a ways from this procedure because of how large the concept is. Also if this topic was re-used I wanted to make sure the pre-req wasn't lost.
aburdenthehand
force-pushed
the
cnv-bz1845198-hugepages
branch
from
875da83
to
239fd18
Compare
|
/cherry-pick enterprise-4.5 |
|
/cherry-pick enterprise-4.6 |
|
@aburdenthehand: new pull request created: #24008 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@aburdenthehand: new pull request created: #24009 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added new assembly to Advanced VM management for configuring VMs to use huge pages. Reusing an OCP concept (conditionalised the final para).
BZ#1845198 - Need documentation around usage of huge-pages