Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ-1857790 Added note about live migration of VMs using HPP #24199

Merged
merged 1 commit into from Aug 12, 2020

Conversation

sjhala-ccs
Copy link
Contributor

@sjhala-ccs sjhala-ccs commented Jul 27, 2020

BZ-1857790 https://bugzilla.redhat.com/show_bug.cgi?id=1857790

Added an explicit note about live migration of VMs created from common templates and using HPP or another storage class with RWO access mode as well as passthrough features such as SRI-OV and GPU.

Preivew build: https://bz-1857790--ocpdocs.netlify.app/openshift-enterprise/latest/virt/virtual_machines/virtual_disks/virt-features-for-storage.html#virt-features-for-storage-matrix_virt-features-for-storage

Tagging @aglitke for SME review
Tagging @rnetser for QE review

Merge/CP to enterprise-4.5 and enterprise-4.6

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@sjhala-ccs sjhala-ccs force-pushed the BZ-1857790 branch 2 times, most recently from 9ef3cca to 74e414d Compare July 28, 2020 15:48
@rnetser
Copy link

rnetser commented Aug 5, 2020

Please add a note that "evictionStrategy: LiveMigrate" should not be configured for these VMs.

@rnetser
Copy link

rnetser commented Aug 10, 2020

/lgtm

@openshift-ci-robot
Copy link

@rnetser: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, but I have one nit and a suggestion that I think would improve readability. Let me know when it's ready to merge. Thanks, Shikha!

modules/virt-features-for-storage-matrix.adoc Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2020
@ousleyp ousleyp merged commit 608932d into openshift:master Aug 12, 2020
@ousleyp
Copy link
Member

ousleyp commented Aug 12, 2020

/cherrypick enterprise-4.5

@ousleyp
Copy link
Member

ousleyp commented Aug 12, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@ousleyp: new pull request created: #24736

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ousleyp: new pull request created: #24737

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.5 branch/enterprise-4.6 CNV Label for all CNV PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants