Skip to content

Conversation

@bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Aug 19, 2021

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2021
@netlify
Copy link

netlify bot commented Aug 19, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: e5d5a22

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6123c6a464163c00070471aa

😎 Browse the preview: https://deploy-preview-35654--osdocs.netlify.app

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021
@Preeticp
Copy link
Contributor

/lgtm

@Preeticp
Copy link
Contributor

@jeana-redhat JFYI

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@Preeticp Preeticp added branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR labels Aug 23, 2021
@Preeticp
Copy link
Contributor

Preeticp commented Aug 23, 2021

Hi @bburt-rh for the issue, your changes are perfect. However, can you please remove: '[id="ocp-4-8-dev-exp"]
=== Developer experience' so that the empty Developer Experience section is not shown in https://deploy-preview-35654--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-8-release-notes.html#ocp-4-8-dev-exp ?
Please squash your commits after you make the change and we can merge this too.

@bburt-rh bburt-rh force-pushed the RHDEVDOCS-2788-48 branch 2 times, most recently from 92ab287 to f4f6f09 Compare August 23, 2021 15:08
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@bburt-rh bburt-rh closed this Aug 23, 2021
@bburt-rh bburt-rh deleted the RHDEVDOCS-2788-48 branch June 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants