Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document the latest changes in must gather for OpenShift Virtualization #38017

Closed
wants to merge 1 commit into from

Conversation

nunnatsa
Copy link
Contributor

Add documentation about must gather for OpenShift Virtualization, that now supports targeted gathering.

Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2021
@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: b3457e9

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6178f0362fe5850007415ca3

😎 Browse the preview: https://deploy-preview-38017--osdocs.netlify.app/openshift-enterprise/latest/virt/logging_events_monitoring/virt-collecting-virt-data

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@tiraboschi
Copy link
Contributor

/assign @ousleyp

@nunnatsa
Copy link
Contributor Author

nunnatsa commented Nov 3, 2021

/cc @ousleyp - clould you please review?

@ousleyp
Copy link
Member

ousleyp commented Nov 3, 2021

/cc @ousleyp - clould you please review?

Hi Nahshon, thank you for providing this! I am going to check out this PR and open a new one so that I can ensure that it meets our docs standards. I'll track my progress in the doc bug. This is next on my list so I will hopefully have a PR soon. This is for the 4.8.4/4.9.1 releases, right? Or do the changes apply to 4.9.0/4.8.0?

@nunnatsa
Copy link
Contributor Author

nunnatsa commented Nov 3, 2021

This is next on my list so I will hopefully have a PR soon. This is for the 4.8.4/4.9.1 releases, right? Or do the changes apply to 4.9.0/4.8.0?

First we want it for 4.10.0, then we want to backport to 4.8.4 and 4.9.1

@ousleyp
Copy link
Member

ousleyp commented Nov 3, 2021

This is next on my list so I will hopefully have a PR soon. This is for the 4.8.4/4.9.1 releases, right? Or do the changes apply to 4.9.0/4.8.0?

First we want it for 4.10.0, then we want to backport to 4.8.4 and 4.9.1

@dankenigsberg Can you please clarify if we need to publish this documentation update before the 4.8.4 release? If not, please let me know when the changes will be live in the product. Thanks!

@dankenigsberg
Copy link
Contributor

This is next on my list so I will hopefully have a PR soon. This is for the 4.8.4/4.9.1 releases, right? Or do the changes apply to 4.9.0/4.8.0?

First we want it for 4.10.0, then we want to backport to 4.8.4 and 4.9.1

@dankenigsberg Can you please clarify if we need to publish this documentation update before the 4.8.4 release? If not, please let me know when the changes will be live in the product. Thanks!

I would defer this question to @nunnatsa. He knows best when his code is merged.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 2, 2022

@nunnatsa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 4, 2022
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Apr 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2022

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants