New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document the latest changes in must gather for OpenShift Virtualization #38017
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: b3457e9 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6178f0362fe5850007415ca3 😎 Browse the preview: https://deploy-preview-38017--osdocs.netlify.app/openshift-enterprise/latest/virt/logging_events_monitoring/virt-collecting-virt-data |
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
a1f8132
to
b3457e9
Compare
|
/assign @ousleyp |
|
/cc @ousleyp - clould you please review? |
Hi Nahshon, thank you for providing this! I am going to check out this PR and open a new one so that I can ensure that it meets our docs standards. I'll track my progress in the doc bug. This is next on my list so I will hopefully have a PR soon. This is for the 4.8.4/4.9.1 releases, right? Or do the changes apply to 4.9.0/4.8.0? |
First we want it for 4.10.0, then we want to backport to 4.8.4 and 4.9.1 |
@dankenigsberg Can you please clarify if we need to publish this documentation update before the 4.8.4 release? If not, please let me know when the changes will be live in the product. Thanks! |
I would defer this question to @nunnatsa. He knows best when his code is merged. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
@nunnatsa: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add documentation about must gather for OpenShift Virtualization, that now supports targeted gathering.
Signed-off-by: Nahshon Unna-Tsameret nunnatsa@redhat.com