Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BZ2017573: CNV-9800 is now TP for 4.9 #38149

Merged
merged 1 commit into from Nov 1, 2021
Merged

BZ2017573: CNV-9800 is now TP for 4.9 #38149

merged 1 commit into from Nov 1, 2021

Conversation

ousleyp
Copy link
Member

@ousleyp ousleyp commented Oct 28, 2021 •
edited

@tiraboschi

@ousleyp ousleyp added this to the Next Release milestone Oct 28, 2021
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2021
@netlify
Copy link

netlify bot commented Oct 28, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: ef4010a

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6180062238320300087448c5

😎 Browse the preview: https://deploy-preview-38149--osdocs.netlify.app

@ousleyp ousleyp changed the title BZ2017573: CNV-9800 is now TP for 4.9 [WIP] BZ2017573: CNV-9800 is now TP for 4.9 Oct 28, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2021
@ousleyp ousleyp changed the title [WIP] BZ2017573: CNV-9800 is now TP for 4.9 BZ2017573: CNV-9800 is now TP for 4.9 Oct 28, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2021
@dbasunag
Copy link

lgtm

sjhala-ccs
sjhala-ccs reviewed Nov 1, 2021
View reviewed changes
Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, otherwise LGTM!

modules/virt-configuring-workload-update-methods.adoc Show resolved Hide resolved
modules/virt-configuring-workload-update-methods.adoc Show resolved Hide resolved
@sjhala-ccs sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 1, 2021
@ousleyp ousleyp merged commit 4d73dde into openshift:main Nov 1, 2021
@ousleyp
Copy link
Member Author

ousleyp commented Nov 1, 2021

/cherrypick enterprise-4.9

@ousleyp
Copy link
Member Author

ousleyp commented Nov 1, 2021

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 1, 2021
Merged
@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #38262

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 1, 2021
Merged
@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #38263

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp ousleyp mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi left review comments

@sjhala-ccs sjhala-ccs sjhala-ccs left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.9 branch/enterprise-4.10 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ousleyp @dbasunag @openshift-cherrypick-robot @tiraboschi @sjhala-ccs