Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ1990953: Only the first container can use SR-IOV network attachment #38234

Merged
merged 1 commit into from Nov 14, 2021

Conversation

jboxman-rh
Copy link

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2021
@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: afd3277

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/617c5d8cc7dee70008647764

😎 Browse the preview: https://deploy-preview-38234--osdocs.netlify.app/openshift-enterprise/latest/networking/hardware_networks/add-pod

@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c4cbf17

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/618ddc5bb187f50008ddc459

😎 Browse the preview: https://deploy-preview-38234--osdocs.netlify.app/openshift-enterprise/latest/networking/hardware_networks/add-pod

@jboxman-rh
Copy link
Author

@zshi-redhat, I re-opened this under a separate PR.

@zshi-redhat
Copy link
Contributor

@zshi-redhat, I re-opened this under a separate PR.

Thanks @jboxman !

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@zshi-redhat
Copy link
Contributor

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Nov 9, 2021

@zshi-redhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

PR title may need to change from BZ-1990953 to Bug1990953

@jboxman-rh jboxman-rh changed the title BZ-1990953: Only the first container can use SR-IOV network attachment BZ1990953: Only the first container can use SR-IOV network attachment Nov 11, 2021
@jboxman-rh
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Nov 11, 2021

@jboxman-rh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one wording thing


If you are using an Intel network interface controller (NIC) in Data Plane Development Kit (DPDK) mode, only the first container in your pod is configured to access the NIC. Your SR-IOV additional network is configured for DPDK mode if the `deviceType` is set to `vfio-pci` in the `SriovNetworkNodePolicy` object.

You can workaround this issue by either ensuring that the container that needs access to the NIC is the first container defined in the `Pod` object or by disabling the Network Resource Injector. For more information, see link:https://bugzilla.redhat.com/show_bug.cgi?id=1990953[BZ#1990953].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe "workaround" is a noun only. If you want to make it a verb, I'd say "You can work around"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergerhoffer oops thanks!

@openshift-ci
Copy link

openshift-ci bot commented Nov 12, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2021
@jboxman-rh jboxman-rh merged commit 54302da into openshift:main Nov 14, 2021
@jboxman-rh jboxman-rh deleted the bz-1990953 branch November 14, 2021 03:11
@jboxman-rh
Copy link
Author

/cherry-pick enterprise-4.10

@openshift-cherrypick-robot

@jboxman-rh: new pull request created: #38696

In response to this:

/cherry-pick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link
Author

/cherry-pick enterprise-4.9

@openshift-cherrypick-robot

@jboxman-rh: new pull request created: #38697

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link
Author

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot

@jboxman-rh: new pull request created: #38698

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link
Author

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@jboxman-rh: new pull request created: #38699

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jboxman-rh
Copy link
Author

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@jboxman-rh: new pull request created: #38700

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants