New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[virt] must-gather changes for 4.9.1/4.8.4 #38786
Conversation
ousleyp
commented
Nov 16, 2021
•
edited
edited
- BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2016429
- Based on a PR submitted by @nunnatsa: document the latest changes in must gather for OpenShift Virtualization #38017
- CP to enterprise-4.10 anytime. When 4.9.1 is released, CP to enterprise-4.9. When 4.8.4 is released, CP to enterprise-4.8
- Note: 4.10 will require additional changes in a different PR
- Preview build: https://deploy-preview-38786--osdocs.netlify.app/openshift-enterprise/latest/virt/logging_events_monitoring/virt-collecting-virt-data#virt-must-gather-usage-targeted-vm-data_virt-collecting-virt-data
2702a62
to
5552c42
Compare
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 2702a620fb65517598c1010e5ba87eb42853c77c 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6193c1162e9f6f0008384274 😎 Browse the preview: https://deploy-preview-38786--osdocs.netlify.app/openshift-enterprise/latest/virt/logging_events_monitoring/virt-collecting-virt-data |
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: afc1d24 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a546e6523b2b0008b503d3 😎 Browse the preview: https://deploy-preview-38786--osdocs.netlify.app |
6e3aff7
to
b7e3dd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples in the original PR are important - there is a meaning to the order and the allowed or supported combination of the parameters.
c7f1a60
to
9371e17
Compare
|
lgtm |
|
Outstanding: I still need to verify if you can use the PROS env var with the gather_images script. (Update: Nahshon confirmed that you can; I updated the doc.) |
66d15f2
to
afc1d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/cherrypick enterprise-4.10 |
|
@ousleyp: new pull request created: #39369 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.9 |
|
@ousleyp: new pull request created: #39822 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.8 |
|
@ousleyp: new pull request created: #40828 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |