Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[virt] must-gather changes for 4.9.1/4.8.4 #38786

Merged
merged 1 commit into from Nov 30, 2021

Conversation

ousleyp
Copy link
Member

@ousleyp ousleyp commented Nov 16, 2021

@ousleyp ousleyp added this to the Next Release milestone Nov 16, 2021
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2021
@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 2702a620fb65517598c1010e5ba87eb42853c77c

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6193c1162e9f6f0008384274

😎 Browse the preview: https://deploy-preview-38786--osdocs.netlify.app/openshift-enterprise/latest/virt/logging_events_monitoring/virt-collecting-virt-data

@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: afc1d24

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a546e6523b2b0008b503d3

😎 Browse the preview: https://deploy-preview-38786--osdocs.netlify.app

Copy link
Contributor

@nunnatsa nunnatsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples in the original PR are important - there is a meaning to the order and the allowed or supported combination of the parameters.

modules/virt-gathering-virt-data.adoc Outdated Show resolved Hide resolved
modules/virt-gathering-virt-data.adoc Outdated Show resolved Hide resolved
@ousleyp ousleyp force-pushed the must-gather-changes branch 2 times, most recently from c7f1a60 to 9371e17 Compare November 23, 2021 14:36
@dbasunag
Copy link

lgtm

@ousleyp
Copy link
Member Author

ousleyp commented Nov 29, 2021

Outstanding: I still need to verify if you can use the PROS env var with the gather_images script. (Update: Nahshon confirmed that you can; I updated the doc.)

Copy link
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjhala-ccs sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 30, 2021
@ousleyp ousleyp merged commit 3e48e82 into openshift:main Nov 30, 2021
@ousleyp
Copy link
Member Author

ousleyp commented Nov 30, 2021

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@ousleyp: new pull request created: #39369

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp
Copy link
Member Author

ousleyp commented Dec 13, 2021

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@ousleyp: new pull request created: #39822

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp
Copy link
Member Author

ousleyp commented Jan 20, 2022

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@ousleyp: new pull request created: #40828

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 CNV Label for all CNV PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants