Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BZ#2021461: MetalLB Operator install errors #38864

Merged
merged 1 commit into from Nov 24, 2021
Merged

BZ#2021461: MetalLB Operator install errors #38864

merged 1 commit into from Nov 24, 2021

Conversation

mikemckiernan
Copy link
Contributor

@mikemckiernan mikemckiernan commented Nov 17, 2021

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 17, 2021
@mikemckiernan mikemckiernan added branch/enterprise-4.9 branch/enterprise-4.10 peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 17, 2021
@mikemckiernan mikemckiernan added this to the Next Release milestone Nov 17, 2021
@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 1fbfee6

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/619e513e17abcf000731fd88

😎 Browse the preview: https://deploy-preview-38864--osdocs.netlify.app/openshift-enterprise/latest/networking/metallb/metallb-operator-install

@mikemckiernan
Copy link
Contributor Author

/assign @asood-rh

PTAL and thank you.

@@ -18,7 +22,7 @@ After you install the Operator, you need to configure a single instance of a Met
[source,terminal]
----
$ cat << EOF | oc apply -f -

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikemckiernan Most of it looks good. I just have a thought of not including prompt sign '$' where ever there is cat << EOF command to allows user to use the clipboard functionality to copy and paste the YAML.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asood-rh, including the prompt is the Red Hat docs convention, but you've uncovered some kind of browser-specific bug that causes the prompt to get included in the paste. I'll investigate that with my team.

Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 24, 2021
@mikemckiernan mikemckiernan merged commit cd97369 into openshift:main Nov 24, 2021
@mikemckiernan
Copy link
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@mikemckiernan: new pull request created: #39245

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikemckiernan
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@mikemckiernan: new pull request created: #39247

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants