Skip to content

Conversation

@jan--f
Copy link
Contributor

@jan--f jan--f commented Mar 4, 2022

…documentation

The field is called sourceLabels not source_labels.

Signed-off-by: Jan Fajerski jfajersk@redhat.com

…documentation

The field is called `sourceLabels` not `source_labels`.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2022
@netlify
Copy link

netlify bot commented Mar 4, 2022

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 91b96a0

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6221d71a6c81180008a936da

😎 Browse the preview: https://deploy-preview-42796--osdocs.netlify.app

@bburt-rh
Copy link
Contributor

bburt-rh commented Mar 4, 2022

lgtm
I'll request a merge

OCP 4.9+, right?

@openshift-ci
Copy link

openshift-ci bot commented Mar 4, 2022

@bburt-rh: changing LGTM is restricted to collaborators

In response to this:

/lgtm
I'll request a merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Preeticp Preeticp added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs peer-review-done Signifies that the peer review team has reviewed this PR lgtm Indicates that a PR is ready to be merged. labels Mar 4, 2022
@bburt-rh
Copy link
Contributor

bburt-rh commented Mar 4, 2022

@jan--f confirmed in Slack that this is for OCP 4.9+

@Preeticp Preeticp added this to the Next Release milestone Mar 4, 2022
@Preeticp Preeticp merged commit a9e497a into openshift:main Mar 4, 2022
@Preeticp
Copy link
Contributor

Preeticp commented Mar 4, 2022

/cherrypick enterprise-4.9

@Preeticp
Copy link
Contributor

Preeticp commented Mar 4, 2022

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@Preeticp: new pull request created: #42829

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@Preeticp: new pull request created: #42830

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 branch/enterprise-4.10 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants