[OSDOCS-3134]: AWS machineset support for EFA #46408
Conversation
openshift-ci
bot
added
the
size/L
jeana-redhat
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jeana-redhat
force-pushed
the
OSDOCS-3134-AWS-EFA-support
branch
from
4624cc3 to
e90e91d
Compare
jeana-redhat
force-pushed
the
OSDOCS-3134-AWS-EFA-support
branch
2 times, most recently
from
be5e744 to
0802f8a
Compare
jeana-redhat
force-pushed
the
OSDOCS-3134-AWS-EFA-support
branch
from
0802f8a to
52f26c1
Compare
jeana-redhat
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
jeana-redhat
force-pushed
the
OSDOCS-3134-AWS-EFA-support
branch
2 times, most recently
from
db6ccd5 to
0945d04
Compare
|
@sunzhaohua2 This is ready for verification. I ended up separating out the steps that are supportive of the use case (as opposed to needed for turning the feature on) into a different task, hope that makes sense :) PTAL and LMK if you ave any questions. |
|
@huali9 PTAL, thanks! |
jeana-redhat
force-pushed
the
OSDOCS-3134-AWS-EFA-support
branch
from
0945d04 to
c384222
Compare
|
Ok! refreshed with all feedback. @huali9, what do you think - is this ready to move along? |
|
Thanks @jeana-redhat |
jeana-redhat
added
the
peer-review-needed
michaelryanpeter
left a comment
michaelryanpeter
left a comment
There was a problem hiding this comment.
Some small nits, a little ISG and a typo.
I am waiting for clarification on one more thing, but I wanted to give you a chance to look things over.
There was a problem hiding this comment.
Hey @sferich888, is this an acceptable time to link to GitHub? AFAIK this is officially where it lives (@JoelSpeed correct me if I'm overlooking a more legit link please)
jeana-redhat
force-pushed
the
OSDOCS-3134-AWS-EFA-support
branch
from
c384222 to
314365d
Compare
|
New changes are detected. LGTM label has been removed. |
|
|
||
| After configuring a machine set to support the use of an AWS Elastic Fabric Adapter (EFA), you must install additional software to run MPI workloads. | ||
|
|
||
| For more information about using Kubeflow and the MPI Operator in {product-title} and an example, see link:https://cloud.redhat.com/blog/how-to-use-kubeflow-and-the-mpi-operator-on-openshift[How to use Kubeflow and the MPI Operator on OpenShift]. |
There was a problem hiding this comment.
Why are we using a blog; as the source of 'how to install' and get setup to use EFA capabilities'?
There was a problem hiding this comment.
Why are we cloning this (from: https://github.com/kubeflow/mpi-operator); vs instilling it from Operator Hub?
jeana-redhat
added
the
do-not-merge/hold
|
Threw a hold on the PR while discussion about the feature is ongoing. |
|
Closing this PR because when we do add this, we will want to do it a bit differently. |
6 participants
Version(s):
4.11
Issue:
OSDOCS-3134 for OCPCLOUD-1353
Link to docs preview:
Machine sets that support using an Elastic Fabric Adapter (requires VPN)
Additional information: