Skip to content

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Jul 21, 2022

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2022
@jldohmann jldohmann changed the title OSDOCS-3853: add new redirector URL [enterprise-4.10] OSDOCS-3853: add new redirector URL Jul 21, 2022
@jldohmann
Copy link
Contributor Author

@mike-nguyen could you PTAL for QE ack? Thank you!

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2022
@jldohmann
Copy link
Contributor Author

@mike-nguyen PTAL for QE ack.

Should we try cherrpicking this to 4.9? I saw that the 4.9 PR was closed, but this one was merged, so I'm not sure which one contained the change 😅

@travier
Copy link
Member

travier commented Aug 2, 2022

This one (openshift/installer#6159) also has the change for 4.9

@mike-nguyen
Copy link
Member

openshift/installer#6159 just merged yesterday and is not officially in a release yet. We will need to cherrypick it at some point to 4.9. 4.8, 4.7, and 4.6 PR's are in the pipeline to update the redirector.

@travier
Copy link
Member

travier commented Aug 2, 2022

I would say that it does not hurt for the doc to be ahead of the update here as it will not create an issue.

So if we have the docs ready let's merge them and they will thus be ready "in advance".

@stevsmit
Copy link
Member

stevsmit commented Aug 2, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2022
@sdodson
Copy link
Member

sdodson commented Aug 2, 2022

/lgtm

@stevsmit
Copy link
Member

stevsmit commented Aug 3, 2022

/cherry-pick enterprise-4.9

@stevsmit
Copy link
Member

stevsmit commented Aug 3, 2022

/cherry-pick enterprise-4.8

@stevsmit
Copy link
Member

stevsmit commented Aug 3, 2022

/cherry-pick enterprise-4.7

@stevsmit
Copy link
Member

stevsmit commented Aug 3, 2022

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@stevsmit: new pull request created: #48729

In response to this:

/cherry-pick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #48730

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stevsmit: new pull request created: #48731

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@stevsmit: #48134 failed to apply on top of branch "enterprise-4.6":

Applying: OSDOCS-3853: add new redirector URL
Using index info to reconstruct a base tree...
M	modules/configuring-firewall.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/configuring-firewall.adoc
CONFLICT (content): Merge conflict in modules/configuring-firewall.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OSDOCS-3853: add new redirector URL
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants