Skip to content

RHDEVDOCS-4274: Added the bug#2069258 in the bug list for OCP 4.9.31 #48897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Preeticp merged 1 commit into from
Aug 24, 2022
Merged

RHDEVDOCS-4274: Added the bug#2069258 in the bug list for OCP 4.9.31 #48897

Preeticp merged 1 commit into from
Aug 24, 2022

Conversation

@shipsing
Copy link
Contributor

@shipsing shipsing commented Aug 9, 2022 •
edited
Loading

Aligned team: Dev Tools

Purpose: To resolve this issue: https://issues.redhat.com/browse/RHDEVDOCS-4274

OCP version this PR applies to: 4.9 Release Notes only

Link to docs preview: Download to see preview in your browser

SME acknowledged in Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2069258 @rottencandy

QE approval needed: @sanketpathak

Peer review completed: @jc-berger

Change Management
Need an ACK from Eng: Provided by @rottencandy
Need an ACK from PM: Provided by @serenamarie125
Need an ACK from Product experience: Provided by @RickJWagner
Need an ACK from QE: Provided by @sanketpathak
Need an ACK from DPM: Provided by @cbremble
Need an ACK from CS: Provided by @TanyaShearonRH

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2022
jc-berger
jc-berger reviewed Aug 10, 2022
View reviewed changes
@shipsing
Copy link
Contributor Author

shipsing commented Aug 16, 2022

@serenamarie125 @RickJWagner, Could you please provide an ack for this PR so that we can proceed with merge?
If you have any comments, you can also share the same.
Thanks

@cbremble
Copy link

cbremble commented Aug 16, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 16, 2022
@TanyaShearonRH
Copy link

TanyaShearonRH commented Aug 16, 2022

/label docs-approved

jc-berger
jc-berger approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 16, 2022

@jc-berger: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RickJWagner
Copy link

RickJWagner commented Aug 16, 2022

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 16, 2022
@shipsing
Copy link
Contributor Author

shipsing commented Aug 17, 2022

@serenamarie125, Could you please provide an ack for this PR so that we can proceed with merge? Rest of the approvals are done.

Thanks

@serenamarie125
Copy link

serenamarie125 commented Aug 18, 2022

/label pm-approved

@openshift-ci
Copy link

openshift-ci bot commented Aug 18, 2022

@serenamarie125: The label(s) /label pm-approved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, cherry-pick-approved

In response to this:

/label pm-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serenamarie125
Copy link

serenamarie125 commented Aug 18, 2022

@shipsing I approve, was trying to use the same labeling technique as Rick & Claire, but doesn't seem to work.

serenamarie125
serenamarie125 approved these changes Aug 18, 2022
View reviewed changes
Copy link

@serenamarie125 serenamarie125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! lgtm

@bburt-rh bburt-rh added peer-review-done Signifies that the peer review team has reviewed this PR dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.9 labels Aug 19, 2022
@bburt-rh bburt-rh added this to the Next Release milestone Aug 19, 2022
@bburt-rh bburt-rh added the qe-approved Signifies that QE has signed off on this PR label Aug 19, 2022
@bburt-rh
Copy link
Contributor

bburt-rh commented Aug 19, 2022

@serenamarie125 Are you the QE approver for this? or the PM? It's not clear in the PR description. It needs QE approval before I can merge it. Thanks!

@bburt-rh bburt-rh removed the qe-approved Signifies that QE has signed off on this PR label Aug 19, 2022
@cbremble
Copy link

cbremble commented Aug 19, 2022

@sanketpathak could you please provide a QE approval for this change to be made to the docs? This is updating the 4.9.31 RN with the doc text you acked in the BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=2069258. Thank you!

bburt-rh
bburt-rh reviewed Aug 19, 2022
View reviewed changes
@shipsing
Copy link
Contributor Author

shipsing commented Aug 22, 2022 •
edited
Loading

Hello @sanketpathak @rottencandy, Could you please review and approve this PR? Thanks

rottencandy
rottencandy approved these changes Aug 22, 2022
View reviewed changes
Copy link

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks.

@sanketpathak
Copy link

sanketpathak commented Aug 22, 2022

LGTM, thanks

@Preeticp Preeticp added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@Preeticp Preeticp merged commit 72bde2a into openshift:enterprise-4.9 Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@bburt-rh bburt-rh bburt-rh left review comments

@serenamarie125 serenamarie125 serenamarie125 approved these changes

@rottencandy rottencandy rottencandy approved these changes

@jc-berger jc-berger jc-berger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.9 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR px-approved Signifies that Product Support has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.