-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[BZ#2117370] Add step for ansible-core migration in 4.10 BYOH updates procedure #48998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BZ#2117370] Add step for ansible-core migration in 4.10 BYOH updates procedure #48998
Conversation
|
LGTM |
barbacbd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peer review LGTM. Please be mindful of the comment I left below regarding steps that instruct users to run a command.
| As of {product-title} 4.11, the Ansible playbooks are provided only for {op-system-base} 8. If a {op-system-base} 7 system was used as a host for the {product-title} 4.10 Ansible playbooks, you must either upgrade the Ansible host to {op-system-base} 8, or create a new Ansible host on a {op-system-base} 8 system and copy over the inventories from the old Ansible host. | ||
| ==== | ||
|
|
||
| .. On the machine that you run the Ansible playbooks, update the Ansible package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is beyond the scope of this PR, but moving forward please be mindful that if a step in a procedure is to run a command, our guidelines specify that the step include some form "run/enter the following command". There are several patterns that can be followed [1].
|
/cherrypick enterprise-4.11 |
|
@kalexand-rh: base branch (enterprise-4.11) needs to differ from target branch (enterprise-4.11) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.12 |
|
@kalexand-rh: new pull request created: #49504 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.11
Issue:
https://bugzilla.redhat.com/show_bug.cgi?id=2117370
Link to docs preview:
http://shell.lab.bos.redhat.com/~yselkowi/openshift-docs/byoh-ansible-core/updating/updating-cluster-rhel-compute.html#rhel-compute-updating-minor_updating-cluster-rhel-compute
Additional information:
openshift-ansible has switched from ansible 2.9 to ansible-core, requiring an additional step in 4.10-to-4.11 upgrades.