Skip to content

Conversation

@yselkowitz
Copy link
Contributor

Version(s):
4.11

Issue:
https://bugzilla.redhat.com/show_bug.cgi?id=2117370

Link to docs preview:
http://shell.lab.bos.redhat.com/~yselkowi/openshift-docs/byoh-ansible-core/updating/updating-cluster-rhel-compute.html#rhel-compute-updating-minor_updating-cluster-rhel-compute

Additional information:
openshift-ansible has switched from ansible 2.9 to ansible-core, requiring an additional step in 4.10-to-4.11 upgrades.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2022
@yselkowitz yselkowitz marked this pull request as ready for review August 11, 2022 15:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2022
@yselkowitz
Copy link
Contributor Author

For Dev and QE review:
/cc @barbacbd @gpei

@openshift-ci openshift-ci bot requested review from barbacbd and gpei August 11, 2022 15:48
@gpei
Copy link

gpei commented Aug 15, 2022

LGTM

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2022
Copy link
Contributor

@mjpytlak mjpytlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review LGTM. Please be mindful of the comment I left below regarding steps that instruct users to run a command.

As of {product-title} 4.11, the Ansible playbooks are provided only for {op-system-base} 8. If a {op-system-base} 7 system was used as a host for the {product-title} 4.10 Ansible playbooks, you must either upgrade the Ansible host to {op-system-base} 8, or create a new Ansible host on a {op-system-base} 8 system and copy over the inventories from the old Ansible host.
====

.. On the machine that you run the Ansible playbooks, update the Ansible package:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is beyond the scope of this PR, but moving forward please be mindful that if a step in a procedure is to run a command, our guidelines specify that the step include some form "run/enter the following command". There are several patterns that can be followed [1].

[1] https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#code-blocks-command-syntax-and-example-output

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@kalexand-rh: base branch (enterprise-4.11) needs to differ from target branch (enterprise-4.11)

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #49504

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz yselkowitz deleted the byoh-4-11-upgrade branch August 23, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 branch/enterprise-4.12 lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants