New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

advanced_install: installer as system container #5258

Merged
merged 2 commits into from Jan 17, 2018

Conversation

@sosiouxme
Member

sosiouxme commented Sep 13, 2017

Simplify slightly and also note some things that were not apparent.

I would like to go on to describe using the container from docker, but I thought it would be good to fix up what's there first.

Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Sep 14, 2017

Member

@openshift/team-documentation these are changes for 3.6 and origin ... hopefully by the time 3.7 rolls around we will have an updated atomic with a better workflow and no longer tech preview.

EDIT: actually the better workflow is here already :) Updated...

Member

sosiouxme commented Sep 14, 2017

@openshift/team-documentation these are changes for 3.6 and origin ... hopefully by the time 3.7 rolls around we will have an updated atomic with a better workflow and no longer tech preview.

EDIT: actually the better workflow is here already :) Updated...

@sosiouxme

Updated per things I discovered about the atomic install command just now.

Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
Show outdated Hide outdated install_config/install/advanced_install.adoc Outdated
@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Sep 14, 2017

Member

@sosiouxme thank you for working on this!

Member

ashcrow commented Sep 14, 2017

@sosiouxme thank you for working on this!

@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Sep 15, 2017

Member

I added a commit to also discuss running the installer image via Docker. This can be worked on separately if preferred, though they are closely related.

Member

sosiouxme commented Sep 15, 2017

I added a commit to also discuss running the installer image via Docker. This can be worked on separately if preferred, though they are closely related.

@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Nov 9, 2017

Member

@openshift/team-documentation can this PR get some love?

Member

sosiouxme commented Nov 9, 2017

@openshift/team-documentation can this PR get some love?

@vikram-redhat

This comment has been minimized.

Show comment
Hide comment
@vikram-redhat

vikram-redhat Nov 9, 2017

Contributor

@sosiouxme is this for 3.7?

Contributor

vikram-redhat commented Nov 9, 2017

@sosiouxme is this for 3.7?

@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Nov 10, 2017

Member

@vikram-redhat it's not specific to 3.7, it's been relevant since it was written two months ago. 3.7 does not block on getting this in, if that's what you're asking.

Member

sosiouxme commented Nov 10, 2017

@vikram-redhat it's not specific to 3.7, it's been relevant since it was written two months ago. 3.7 does not block on getting this in, if that's what you're asking.

@giuseppe

This comment has been minimized.

Show comment
Hide comment
@giuseppe

giuseppe Jan 11, 2018

@sosiouxme could you please rebase this PR? It looks like this change didn't get it, and the documentation still reports the old way of using the system container installer.

giuseppe commented Jan 11, 2018

@sosiouxme could you please rebase this PR? It looks like this change didn't get it, and the documentation still reports the old way of using the system container installer.

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 11, 2018

Member

👍 we've had some confusion over usage and I think this PR clears things up.

Member

ashcrow commented Jan 11, 2018

👍 we've had some confusion over usage and I think this PR clears things up.

advanced_install: installer image
Update, simplify, and also note some things that were not apparent about
running as a system container.
Rearrange containerized install material to enable discussion of running
it as a Docker container.
@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Jan 11, 2018

Member

@giuseppe @ashcrow sure thing guys.
@vikram-redhat can this get moving now?

Member

sosiouxme commented Jan 11, 2018

@giuseppe @ashcrow sure thing guys.
@vikram-redhat can this get moving now?

@vikram-redhat

This comment has been minimized.

Show comment
Hide comment
@vikram-redhat

vikram-redhat Jan 11, 2018

Contributor

@sosiouxme sorry for the delay. @gaurav-nelson - can you take a look at this today? Also, we need an ack from QE to move this along. @xltian - can someone from QE review this and provide approval?

Also cc: @adellape and @ahardin-rh so that you are aware of this for the install guide.

Contributor

vikram-redhat commented Jan 11, 2018

@sosiouxme sorry for the delay. @gaurav-nelson - can you take a look at this today? Also, we need an ack from QE to move this along. @xltian - can someone from QE review this and provide approval?

Also cc: @adellape and @ahardin-rh so that you are aware of this for the install guide.

@gaurav-nelson

This comment has been minimized.

Show comment
Hide comment
@gaurav-nelson

gaurav-nelson Jan 12, 2018

@sosiouxme Thank you for the PR. I have suggested few updates, not big ones but multiple small ones.

Then I can merge this one after QE checks.

gaurav-nelson commented Jan 12, 2018

@sosiouxme Thank you for the PR. I have suggested few updates, not big ones but multiple small ones.

Then I can merge this one after QE checks.

@ganhuang

This comment has been minimized.

Show comment
Hide comment
@ganhuang

ganhuang Jan 12, 2018

Contributor

cc @wkshi

Contributor

ganhuang commented Jan 12, 2018

cc @wkshi

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 12, 2018

Member

@gaurav-nelson @sosiouxme @wkshi thanks guys for working on this!

Member

ashcrow commented Jan 12, 2018

@gaurav-nelson @sosiouxme @wkshi thanks guys for working on this!

@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Jan 12, 2018

Member

Thanks, I'll fix those up today.

Member

sosiouxme commented Jan 12, 2018

Thanks, I'll fix those up today.

@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Jan 12, 2018

Member

@gaurav-nelson thanks for the review; I think I've addressed everything except #5258 (review) where I have a lingering question.

Member

sosiouxme commented Jan 12, 2018

@gaurav-nelson thanks for the review; I think I've addressed everything except #5258 (review) where I have a lingering question.

@gaurav-nelson

This comment has been minimized.

Show comment
Hide comment
@gaurav-nelson

gaurav-nelson Jan 14, 2018

Thank you @sosiouxme for the updates, I am waiting for QE review before merging this. After that's done, I will do a follow up PR and then we can work on better explanation for your question. Thanks again!

gaurav-nelson commented Jan 14, 2018

Thank you @sosiouxme for the updates, I am waiting for QE review before merging this. After that's done, I will do a follow up PR and then we can work on better explanation for your question. Thanks again!

@wkshi

Looks good to me.(QE side)

@ashcrow

This comment has been minimized.

Show comment
Hide comment
@ashcrow

ashcrow Jan 16, 2018

Member

@gaurav-nelson looks like we got QE approval 🎆 🎆

Member

ashcrow commented Jan 16, 2018

@gaurav-nelson looks like we got QE approval 🎆 🎆

@gaurav-nelson gaurav-nelson merged commit ebae7ec into openshift:master Jan 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaurav-nelson gaurav-nelson added this to the Next Release milestone Jan 17, 2018

@sosiouxme sosiouxme deleted the sosiouxme:20170913-containerized-installer branch Jan 17, 2018

@sosiouxme

This comment has been minimized.

Show comment
Hide comment
@sosiouxme

sosiouxme Jan 17, 2018

Member

👏

Member

sosiouxme commented Jan 17, 2018

👏

@adellape

This comment has been minimized.

Show comment
Hide comment
@adellape

adellape Feb 9, 2018

Contributor

@gaurav-nelson I'm getting a lot of conflicts trying to pick something else from master to 3.9-stage, and I think it's because this PR should have gotten picked to 3.9 when it was picked to 3.6 and 3.7. I'm gonna try doing that.

Contributor

adellape commented Feb 9, 2018

@gaurav-nelson I'm getting a lot of conflicts trying to pick something else from master to 3.9-stage, and I think it's because this PR should have gotten picked to 3.9 when it was picked to 3.6 and 3.7. I'm gonna try doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment