Skip to content

TELCODOCS-930: RN Document new features #56147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

TELCODOCS-930: RN Document new features #56147

merged 1 commit into from
Mar 17, 2023

Conversation

@kdrake20
Copy link
Contributor

@kdrake20 kdrake20 commented Feb 20, 2023 •
edited
Loading

Fixes: TELCODOCS-930

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Tothill ktothill@redhat.com

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2023 •
edited by openshift-ci bot
Loading

@ktothill: This pull request references TELCODOCS-930 which is a valid jira issue.

In response to this:

Fixes: TELCODOCS-930

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Tothill ktothill@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 20, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 20, 2023 •
edited
Loading

🤖 Updated build preview is available at:
https://56147--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11410

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2023 •
edited by openshift-ci bot
Loading

@ktothill: This pull request references TELCODOCS-930 which is a valid jira issue.

In response to this:

Fixes: TELCODOCS-930

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Tothill ktothill@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdrake20
Copy link
Contributor Author

kdrake20 commented Feb 20, 2023

CM email sent 2/20.

@kdrake20 kdrake20 changed the title TELCODOCS-930: Document new features TELCODOCS-930 RN: Document new features Feb 20, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2023

@ktothill: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Fixes: TELCODOCS-930

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Tothill ktothill@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdrake20 kdrake20 changed the title TELCODOCS-930 RN: Document new features TELCODOCS-930: RN Document new features Feb 20, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2023 •
edited by openshift-ci bot
Loading

@ktothill: This pull request references TELCODOCS-930 which is a valid jira issue.

In response to this:

Fixes: TELCODOCS-930

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Tothill ktothill@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kdrake20
Copy link
Contributor Author

kdrake20 commented Feb 20, 2023

Awaiting merge of PR 55899 before rebasing and requesting merge to avoid conflicts.

@oourfali
Copy link

oourfali commented Feb 20, 2023

looks good to me. Only question, regarding Nutanix, is whether we somehow need to mention it is SaaS only? We do mention UI + REST-API, but is that enough, or we should explicitly mention we're talking about the SaaS UI, rather than CIM?
@filanov will appreciate a review by you as well.

cybertron
cybertron reviewed Feb 20, 2023
View reviewed changes
@filanov
Copy link

filanov commented Feb 20, 2023

+1 to @oourfali comment, currently it's supported only in SAAS, we plan to add the support for kube-api in 2.8

@filanov
Copy link

filanov commented Feb 20, 2023 •
edited
Loading

There is additional feature that we added and can be documented MGMT-11058 Support setting kernel parameters for discovery

@kdrake20
Copy link
Contributor Author

kdrake20 commented Feb 20, 2023

Reached out to @johnwilkins and @rohennes to confirm answers to Oved, Ben and Michael's questions.

@kdrake20
Copy link
Contributor Author

kdrake20 commented Feb 21, 2023

There is additional feature that we added and can be documented MGMT-11058 Support setting kernel parameters for discovery

Added RN as requested.

@openshift-ci openshift-ci bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2023
@kdrake20
Copy link
Contributor Author

kdrake20 commented Feb 21, 2023

Awaiting merge of #55899 before rebasing and requesting merge to avoid conflicts.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2023
@kdrake20
Copy link
Contributor Author

kdrake20 commented Feb 23, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 23, 2023
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 23, 2023
@stevsmit stevsmit added this to the Continuous Release milestone Feb 23, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 10, 2023
@kdrake20
Copy link
Contributor Author

kdrake20 commented Mar 10, 2023

/Label Telco
/Label Peer-Review-Needed

@kdrake20
Copy link
Contributor Author

kdrake20 commented Mar 10, 2023

@chadcrum @trewest, can I please get a review and LGTM if applicable? Thank you!

@racedo
Copy link

racedo commented Mar 13, 2023

/lgtm thanks!

@kdrake20
Copy link
Contributor Author

kdrake20 commented Mar 13, 2023

@chadcrum @trewest, can I please get a review and LGTM if applicable? Thank you!

@kdrake20
Copy link
Contributor Author

kdrake20 commented Mar 13, 2023

/label remove peer-review-in-progress

@kdrake20
Copy link
Contributor Author

kdrake20 commented Mar 13, 2023

/Label Telco
/Label Peer-Review-Needed

@chadcrum
Copy link

chadcrum commented Mar 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@kalexand-rh kalexand-rh removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 15, 2023
kcarmichael08
kcarmichael08 reviewed Mar 15, 2023
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions/questions; otherwise LGTM!

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Mar 15, 2023

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

@kcarmichael08: Those labels are not set on the issue: peer-review-in-progress

In response to this:

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2023

New changes are detected. LGTM label has been removed.

@kdrake20
Copy link
Contributor Author

kdrake20 commented Mar 17, 2023

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 17, 2023
@jboxman-rh jboxman-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 17, 2023
@jboxman-rh jboxman-rh merged commit 0a1f2c9 into openshift:enterprise-4.12 Mar 17, 2023
@jboxman-rh jboxman-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 17, 2023
This was referenced Mar 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

+4 more reviewers

@cybertron cybertron cybertron left review comments

@danmacpherson danmacpherson danmacpherson left review comments

@racedo racedo racedo left review comments

@adellape adellape adellape left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@cybertron cybertron

@chadcrum chadcrum

Labels

branch/enterprise-4.12 branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.