Skip to content

Conversation

@jneczypor
Copy link
Contributor

@jneczypor jneczypor commented Sep 18, 2023

OSDOCS-7766: Migrate "Enabling the AWS EFS CSI Driver Operator on ROSA" to ROSA product documentation

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-7766

Link to docs preview:
https://64868--docspreview.netlify.app/openshift-rosa/latest/rosa_tutorials/rosa-mobb-enabling-aws-efs-csi-driver-operator-rosa

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 18, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2023

@jneczypor: This pull request references OSDOCS-7766 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7766: Migrate "Enabling the AWS EFS CSI Driver Operator on ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7766

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 18, 2023

@jneczypor: This pull request references OSDOCS-7766 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7766: Migrate "Enabling the AWS EFS CSI Driver Operator on ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7766

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 18, 2023
@jneczypor jneczypor force-pushed the OSDOCS-7766 branch 3 times, most recently from ef3c095 to 9077afc Compare September 20, 2023 13:47
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 20, 2023

🤖 Updated build preview is available at:
https://64868--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/25320

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 20, 2023

@jneczypor: This pull request references OSDOCS-7766 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7766: Migrate "Enabling the AWS EFS CSI Driver Operator on ROSA" to ROSA product documentation

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OSDOCS-7766

Link to docs preview:
https://64868--docspreview.netlify.app/openshift-rosa/latest/rosa_tutorials/rosa-mobb-enabling-aws-efs-csi-driver-operator-rosa

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tmalove
Copy link
Contributor

tmalove commented Sep 20, 2023

@jneczypor Don't forget to squash your commits before the merge request...looks good with a few suggestions (some for the next round). Thanks!

@jneczypor
Copy link
Contributor Author

Hi @michaelryanmcneill - Can I please have a review of this PR? Thanks so much!

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@duanwei33
Copy link

Hello, I 'm OCP storge QE and we are just reviewing ROSA & AWS EFS CSI Driver Operator in #64612, may I know what is the difference between them?

Also I'm not sure do we need this section under Tutorials while we have the EFS operator installation in following section?
https://64868--docspreview.netlify.app/openshift-rosa/latest/storage/container_storage_interface/osd-persistent-storage-aws-efs-csi

cc @ropatil010

@michaelryanmcneill
Copy link
Contributor

/hold

In agreement with @duanwei33: I'm not confident it makes sense to put this in Tutorials. I'm going to verify the existing doc matches the tutorial doc. If so, we'll close this in favor of that.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2023

@jneczypor: This pull request references OSDOCS-7766 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

OSDOCS-7766: Migrate "Enabling the AWS EFS CSI Driver Operator on ROSA" to ROSA product documentation

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-7766

Link to docs preview:
https://64868--docspreview.netlify.app/openshift-rosa/latest/rosa_tutorials/rosa-mobb-enabling-aws-efs-csi-driver-operator-rosa

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2024

@jneczypor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-asciidoc 448bf12 link true /test validate-asciidoc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 10, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 10, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jun 10, 2024
@openshift-ci
Copy link

openshift-ci bot commented Jun 10, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants