Skip to content

Conversation

@eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Sep 27, 2023

This is a manual cherry-pick of #63525 into the standalone.
Pipeline version for cherry-picking: pipelines-docs-1.12
Preview: https://65303--docspreview.netlify.app/openshift-pipelines/latest/pac/pac-command-reference#configuring-pipelines-as-code-logging_pac-command-reference

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 27, 2023

🤖 Updated build preview is available at:
https://65303--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26167

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 27, 2023
@mramendi
Copy link
Contributor

/label merge-review-needed

Note: SME. QE, and peer review is already done in #63525 ; only a merge revie and merging remain. The placement of the web UI in CLI reference happens because of a pre-existing absence of CLI information in the logging assembly, which we had no time to fix 1.12 and we will target a fix for 1.13: https://issues.redhat.com/browse/RHDEVDOCS-5636 . I am creating this label as I am the lea writer on Pipelines and this was pending my review.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 27, 2023
@mburke5678 mburke5678 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 27, 2023
@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 27, 2023
@mburke5678
Copy link
Contributor

@ekristova @mramendi Is this PR waiting for GA like 63525?

@mramendi
Copy link
Contributor

@mburke5678 things happened :) 63525 will not be merged, because Pipelines documentation has now moved to a standalone branch. So all PRs that were not yet merged have been cherry-picked into the new branches - pipeline-docs is the "main" for Pipelines, while pipelines-docs-1.12 is the version branch.

Things can be merged anytime with the new system, we just publish (or more exactly "make user-visible") the new version on GA date.

Regarding this PR, Eliska has a public holiday on Thursday, while GA is on Thursday too. I can't push into her branch. Eliska might log in in the morning and do the changes; if she does not, I will create a new PR in the afternoon with the suggested changes in it and request merge review again.

@eromanova97
Copy link
Contributor Author

Requested changes are done :)

@mburke5678 mburke5678 merged commit a7e8532 into openshift:pipelines-docs Sep 28, 2023
@mburke5678
Copy link
Contributor

/cherrypick pipelines-docs-1.12

1 similar comment
@mburke5678
Copy link
Contributor

/cherrypick pipelines-docs-1.12

@openshift-cherrypick-robot

@mburke5678: new pull request created: #65403

In response to this:

/cherrypick pipelines-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants