Skip to content

[enterprise-4.16] OSDOCS-6182: add RN entry #75640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2024
Merged

[enterprise-4.16] OSDOCS-6182: add RN entry #75640

merged 1 commit into from
May 14, 2024

Conversation

@jldohmann
Copy link
Contributor

@jldohmann jldohmann commented May 7, 2024 •
edited
Loading

@jldohmann jldohmann added this to the Planned for 4.16 GA milestone May 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-6182 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/OSDOCS-6182

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-6182 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/OSDOCS-6182

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 7, 2024 •
edited
Loading

🤖 Tue May 14 19:40:52 - Prow CI generated the docs preview:

https://75640--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html

@jldohmann
Copy link
Contributor Author

jldohmann commented May 10, 2024

@melvinjoseph86 could you PTAL at this docs PR for QE ack? this is the OCP 4.16 release note entry for improved coredns integration with egress firewall

melvinjoseph86
melvinjoseph86 reviewed May 13, 2024
View reviewed changes
@melvinjoseph86
Copy link

melvinjoseph86 commented May 13, 2024

Rest fine.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-6182 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/OSDOCS-6182

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-6182 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/OSDOCS-6182

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label May 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 13, 2024 •
edited by openshift-ci bot
Loading

@jldohmann: This pull request references OSDOCS-6182 which is a valid jira issue.

In response to this:

Version(s): 4.16

Issue: https://issues.redhat.com/browse/OSDOCS-6182

Link to docs preview: https://75640--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-16-release-notes.html#ocp-4-16-coredns-improved-egress-firewall

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 14, 2024
kcarmichael08
kcarmichael08 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment/suggestion; otherwise lgtm!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 14, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2024

@jldohmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jldohmann jldohmann merged commit 187bc73 into openshift:enterprise-4.16 May 14, 2024
@jldohmann jldohmann deleted the OSDOCS-6182-RN branch May 14, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

+1 more reviewer

@melvinjoseph86 melvinjoseph86 melvinjoseph86 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.16 GA

Development

Successfully merging this pull request may close these issues.

5 participants

@jldohmann @openshift-ci-robot @ocpdocs-previewbot @melvinjoseph86 @kcarmichael08