Skip to content

Conversation

@kcarmichael08
Copy link
Contributor

@kcarmichael08 kcarmichael08 commented Jun 6, 2024

Version(s):

RHACS 4.4+

Issue

Link to docs preview

QE review: (ACS has no QE, reviewed/ack'd by SME)

  • QE has approved this change.

Additional information:

Modeled on the ROSA matrix, should we have more rows/columns, and if so, what should be in here?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@kcarmichael08: This pull request references ROX-23494 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.4+

Issue

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 6, 2024

🤖 Tue Jul 16 20:54:37 - Prow CI generated the docs preview:

https://77107--ocpdocs-pr.netlify.app/openshift-acs/latest/cloud_service/acs-cloud-responsibility-matrix.html

@kcarmichael08 kcarmichael08 force-pushed the ROX-23494-responsibility-matrix branch 2 times, most recently from be99eac to 05cbaac Compare June 6, 2024 20:50
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2024

@kcarmichael08: This pull request references ROX-23494 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.4+

Issue

Link to docs preview

QE review:

  • QE has approved this change.

Additional information:

Modeled on the ROSA matrix, should we have more rows/columns, and if so, what should be in here?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 force-pushed the ROX-23494-responsibility-matrix branch 5 times, most recently from 595c26e to fbc5064 Compare July 3, 2024 19:12
Copy link

@mclasmeier mclasmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly sure what "Control plane" refers to.

@kcarmichael08 kcarmichael08 force-pushed the ROX-23494-responsibility-matrix branch from fbc5064 to 548a778 Compare July 15, 2024 17:29
@kcarmichael08
Copy link
Contributor Author

Not exactly sure what "Control plane" refers to.

I have rewritten to try to clarify. I think this was leftover language from ROSA that's not really applicable here.

@kcarmichael08 kcarmichael08 force-pushed the ROX-23494-responsibility-matrix branch 2 times, most recently from 18d0f21 to 499cece Compare July 15, 2024 19:15
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@kcarmichael08: This pull request references ROX-23494 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.4+

Issue

Link to docs preview

QE review: (ACS has no QE, reviewed/ack'd by SME)

  • QE has approved this change.

Additional information:

Modeled on the ROSA matrix, should we have more rows/columns, and if so, what should be in here?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@kcarmichael08: This pull request references ROX-23494 which is a valid jira issue.

In response to this:

Version(s):

RHACS 4.4+

Issue

Link to docs preview

QE review: (ACS has no QE, reviewed/ack'd by SME)

  • QE has approved this change.

Additional information:

Modeled on the ROSA matrix, should we have more rows/columns, and if so, what should be in here?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 15, 2024
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 16, 2024
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments, but looks good overall!

[id="acs-cloud-responsibilities_{context}"]
= Shared responsibilities for {product-title-managed-short}

While Red Hat manages the {product-title-managed-short} services, also referred to as Central services, the customer has certain responsibilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you're defining Central services here, I think it can be italicized, per IBM Style: https://www.ibm.com/docs/en/ibm-style?topic=format-highlighting#highlighting-by-style

Suggested change
While Red Hat manages the {product-title-managed-short} services, also referred to as Central services, the customer has certain responsibilities.
While Red Hat manages the {product-title-managed-short} services, also referred to as _Central services_, the customer has certain responsibilities.

|Red Hat responsibility
|Customer responsibility


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throughout the following table, unless a word must remain all lowercase for some reason, use the initial cap for each item. For example:
* Platform monitoring
* Software updates
* High availability

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 16, 2024
@kcarmichael08 kcarmichael08 force-pushed the ROX-23494-responsibility-matrix branch from 499cece to c34f70b Compare July 16, 2024 20:18
@kcarmichael08 kcarmichael08 force-pushed the ROX-23494-responsibility-matrix branch from c34f70b to afeeac7 Compare July 16, 2024 20:32
@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2024

@kcarmichael08: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit e43b2cd into openshift:rhacs-docs-main Jul 16, 2024
@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.4

@kcarmichael08
Copy link
Contributor Author

/cherrypick rhacs-docs-4.5

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #78966

In response to this:

/cherrypick rhacs-docs-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@kcarmichael08: new pull request created: #78967

In response to this:

/cherrypick rhacs-docs-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants