Skip to content

Conversation

@Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented Jun 20, 2024

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6080

Link to docs preview:

Replaced apiVersion: argoproj.io/v1beta1 with apiVersion: argoproj.io/v1alpha1 in the following sections:

QE review:

  • QE has approved this change.

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97
Peer review:

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2024
@Dhruv-Soni11 Dhruv-Soni11 changed the title Replace v1alpha1 in RolloutManager sections RHDEVDOCS-6080: Replace v1alpha1 in RolloutManager sections Jun 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 20, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 20, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6080

Link to docs preview:

Changed apiVersion: argoproj.io/v1beta1 -> apiVersion: argoproj.io/v1alpha1 in the following sections:

  • About RolloutManager custom resources and specification
  • Creating a RolloutManager custom resource

QE review:

  • QE has approved this change.

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6080

Link to docs preview:

Changed apiVersion: argoproj.io/v1beta1 -> apiVersion: argoproj.io/v1alpha1 in the following sections:

QE review:

  • QE has approved this change.

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 20, 2024

@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6080

Link to docs preview:

Replaced apiVersion: argoproj.io/v1beta1 with apiVersion: argoproj.io/v1alpha1 in the following sections:

QE review:

  • QE has approved this change.

SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@varshab1210
Copy link

LGTM, thanks

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 20, 2024
@smunje1
Copy link
Contributor

smunje1 commented Jun 20, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 20, 2024
@smunje1
Copy link
Contributor

smunje1 commented Jun 20, 2024

/remove-label peer-review-in-progress
/label peer-review-done

@smunje1
Copy link
Contributor

smunje1 commented Jun 20, 2024

@Dhruv-Soni11 Peer review, LGTM!

@Dhruv-Soni11
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR merge-review-needed Signifies that the merge review team needs to review this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 20, 2024
@ShaunaDiaz ShaunaDiaz added gitops and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jun 20, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jun 20, 2024
@ShaunaDiaz
Copy link
Contributor

@Dhruv-Soni11 This PR looks OK to merge, but it can't be until rebased against the gitops-docs-main branch.

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2024

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Dhruv-Soni11
Copy link
Contributor Author

@Dhruv-Soni11 This PR looks OK to merge, but it can't be until rebased against the gitops-docs-main branch.

Hello @ShaunaDiaz - I have fixed the rebase issue against the gitops-docs-main branch. PTAL. Thanks.

@ShaunaDiaz ShaunaDiaz merged commit ba572f7 into openshift:gitops-docs-main Jun 21, 2024
@ShaunaDiaz
Copy link
Contributor

/cherrypick gitops-docs-1.10

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #77833

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ShaunaDiaz
Copy link
Contributor

/cherrypick gitops-docs-1.11

@ShaunaDiaz
Copy link
Contributor

/cherrypick gitops-docs-1.12

@ShaunaDiaz
Copy link
Contributor

/cherrypick gitops-docs-1.13

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #77834

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #77835

In response to this:

/cherrypick gitops-docs-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #77836

In response to this:

/cherrypick gitops-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants