-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-6080: Replace v1alpha1 in RolloutManager sections #77730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-6080: Replace v1alpha1 in RolloutManager sections #77730
Conversation
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Fri Jun 21 08:06:41 - Prow CI generated the docs preview: |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Dhruv-Soni11: This pull request references RHDEVDOCS-6080 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
LGTM, thanks |
jgwest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
|
/label peer-review-needed |
|
/label peer-review-in-progress |
|
/remove-label peer-review-in-progress |
|
@Dhruv-Soni11 Peer review, LGTM! |
|
/label merge-review-needed |
|
@Dhruv-Soni11 This PR looks OK to merge, but it can't be until rebased against the |
e1ca2b3 to
b657c45
Compare
|
@Dhruv-Soni11: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hello @ShaunaDiaz - I have fixed the rebase issue against the gitops-docs-main branch. PTAL. Thanks. |
|
/cherrypick gitops-docs-1.10 |
|
@ShaunaDiaz: new pull request created: #77833 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick gitops-docs-1.11 |
|
/cherrypick gitops-docs-1.12 |
|
/cherrypick gitops-docs-1.13 |
|
@ShaunaDiaz: new pull request created: #77834 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #77835 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #77836 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
GitOps 1.10, GitOps 1.11, GitOps 1.12, GitOps 1.13
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-6080
Link to docs preview:
Replaced apiVersion: argoproj.io/v1beta1 with apiVersion: argoproj.io/v1alpha1 in the following sections:
QE review:
SME review: @jgwest
QE review: @varshab1210
Internal peer review: @eromanova97
Peer review:
Additional information: