Skip to content

OADP-4594: Update OADP channel documentation #79577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

OADP-4594: Update OADP channel documentation #79577

merged 1 commit into from
Jul 29, 2024

Conversation

@anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Jul 26, 2024 •
edited
Loading

Jira

Version(s):

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references OADP-4594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2024
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references OADP-4594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Jira

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references OADP-4594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Jira

Version(s):

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 26, 2024

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Jul 26, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 26, 2024 •
edited
Loading

🤖 Mon Jul 29 18:54:51 - Prow CI generated the docs preview:

https://79577--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jul 26, 2024
View reviewed changes
anarnold97
anarnold97 commented Jul 26, 2024
View reviewed changes
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 26, 2024 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references OADP-4594 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Jira

Version(s):

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97 anarnold97 force-pushed the OADP-4594-update-OADP-channel-documentation branch from da89d8a to 7484f6f Compare July 26, 2024 14:38
@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 26, 2024

Should I bring across this table into the docs

image

stillalearner
stillalearner approved these changes Jul 29, 2024
View reviewed changes
Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

weshayutin
weshayutin reviewed Jul 29, 2024
View reviewed changes
modules/about-oadp-update-channels.adoc Outdated
* The *stable-1.1* channel is deprecated and is not supported.
* The *stable-1.2* channel contains `oadp.v1.2._z_`, the most recent OADP 1.2 `ClusterServiceVersion`.
* The *stable-1.2* channel contains `{oadp-short}.v1.2._z_`, the most recent {oadp-short} 1.2 `ClusterServiceVersion`.
Copy link

@weshayutin weshayutin Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OADP-1.2 is also deprecrecated and NOT supported.

anarnold97
anarnold97 commented Jul 29, 2024
View reviewed changes
@anarnold97 anarnold97 force-pushed the OADP-4594-update-OADP-channel-documentation branch from bf59378 to 5010e85 Compare July 29, 2024 12:03
@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 29, 2024

@rayfordj - these changes good with you? thanks

rayfordj
rayfordj approved these changes Jul 29, 2024
View reviewed changes
Copy link

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
@rayfordj rayfordj removed their assignment Jul 29, 2024
@anarnold97 anarnold97 changed the title WIP - OADP-4594: Update OADP channel documentation OADP-4594: Update OADP channel documentation Jul 29, 2024
@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 29, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-needed Signifies that the peer review team needs to review this PR and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 29, 2024
weshayutin
weshayutin approved these changes Jul 29, 2024
View reviewed changes
Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@dfitzmau
Copy link
Contributor

dfitzmau commented Jul 29, 2024

/remove-label peer-review-needed

/label peer-review-in-progress

@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 29, 2024

@kcarmichael08 Thanks. Sachin Singla from QE approved - #79577 (review)

@anarnold97
Copy link
Contributor Author

anarnold97 commented Jul 29, 2024

QE approved
Dev approved
Release engineering approved

I think i covered all bases! LOL

@weshayutin
Copy link

weshayutin commented Jul 29, 2024

QE approved Dev approved Release engineering approved

I think i covered all bases! LOL

don't forget KID tested, Mother approved. https://www.kixcereal.com/products/

@kcarmichael08 kcarmichael08 merged commit 639f02a into openshift:main Jul 29, 2024
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.12

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 29, 2024

@kcarmichael08: new pull request created: #79663

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2024
Merged
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.14

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 29, 2024

@kcarmichael08: new pull request created: #79664

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 29, 2024

@kcarmichael08: new pull request created: #79665

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 29, 2024

@kcarmichael08: new pull request created: #79666

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2024
Merged
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.16

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jul 29, 2024

/cherrypick enterprise-4.17

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 29, 2024

@kcarmichael08: new pull request created: #79667

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 29, 2024

@kcarmichael08: new pull request created: #79668

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfitzmau dfitzmau dfitzmau left review comments

+4 more reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@weshayutin weshayutin weshayutin approved these changes

@rayfordj rayfordj rayfordj approved these changes

@stillalearner stillalearner stillalearner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weshayutin weshayutin

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@anarnold97 @openshift-ci-robot @ocpdocs-previewbot @dfitzmau @kcarmichael08 @weshayutin @openshift-cherrypick-robot @rayfordj @stillalearner @ocpdocs-vale-bot