Skip to content

Conversation

@rh-tokeefe
Copy link
Contributor

@rh-tokeefe rh-tokeefe commented Aug 1, 2024

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is not officially released yet. The project is seeking feedback from early adopters.

Versions: Tech Preview

PRs get merged to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-main

And cherry picked to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-1.0tp1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview: https://79884--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@rh-tokeefe: This pull request references OLS-893 which is a valid jira issue.

In response to this:

Version(s): Tech Preview cp to TP1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2024
@JoaoFula
Copy link
Contributor

JoaoFula commented Aug 6, 2024

LGTM

@rh-tokeefe rh-tokeefe force-pushed the OLS-893 branch 2 times, most recently from e52f1cf to 6004e05 Compare August 6, 2024 22:02
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2024

@rh-tokeefe: This pull request references OLS-893 which is a valid jira issue.

In response to this:

Version(s): Tech Preview cp to TP1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title OLS-893: Minor OpenShift Lightspeed docs edits [WIP] OLS-893: Minor OpenShift Lightspeed docs edits Aug 7, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024

@rh-tokeefe: This pull request references OLS-893 which is a valid jira issue.

In response to this:

Version(s): Tech Preview cp to TP1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview: https://79884--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024

@rh-tokeefe: This pull request references OLS-893 which is a valid jira issue.

In response to this:

Version(s): Tech Preview cp to TP1

PRs get merged to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-main

And cherry picked to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-1.0tp1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview: https://79884--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024

@rh-tokeefe: This pull request references OLS-893 which is a valid jira issue.

In response to this:

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is not officially released yet.

Versions: Tech Preview

PRs get merged to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-main

And cherry picked to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-1.0tp1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview: https://79884--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Aug 8, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few suggestions/comments and a question about this file about/ols-openshift-lightspeed-overview.adoc. Otherwise nice work! Thanks!

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 8, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2024
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2024

@rh-tokeefe: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe rh-tokeefe changed the title [WIP] OLS-893: Minor OpenShift Lightspeed docs edits OLS-893: Minor OpenShift Lightspeed docs edits Aug 9, 2024
@rh-tokeefe
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added merge-review-needed Signifies that the merge review team needs to review this PR and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 9, 2024

@rh-tokeefe: This pull request references OLS-893 which is a valid jira issue.

In response to this:

This PR is part of the standalone doc set for the Lightspeed project. Kathryn is aware that this content applies for a product that is not officially released yet. The project is seeking feedback from early adopters.

Versions: Tech Preview

PRs get merged to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-main

And cherry picked to https://github.com/openshift/openshift-docs/tree/lightspeed-docs-1.0tp1

Issue: https://issues.redhat.com/browse/OLS-893

Link to docs preview: https://79884--ocpdocs-pr.netlify.app/openshift-lightspeed/latest/configure/ols-configuring-openshift-lightspeed.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rh-tokeefe rh-tokeefe changed the title OLS-893: Minor OpenShift Lightspeed docs edits OLS-893: OpenShift Lightspeed docs edits Aug 9, 2024
@adellape adellape self-assigned this Aug 9, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 9, 2024
@adellape adellape added this to the Continuous Release milestone Aug 9, 2024
@adellape adellape merged commit fae9fdd into openshift:lightspeed-docs-main Aug 9, 2024
@adellape
Copy link
Contributor

adellape commented Aug 9, 2024

/cherrypick lightspeed-docs-1.0tp1

@openshift-cherrypick-robot

@adellape: new pull request created: #80328

In response to this:

/cherrypick lightspeed-docs-1.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants