Skip to content

Conversation

@jherrman
Copy link
Contributor

@jherrman jherrman commented Sep 6, 2024

Version(s):
4.17

Issue:
https://issues.redhat.com/browse/CNV-38323

Link to docs preview:
https://81418--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

QE review:

  • QE has approved this change.

Additional information:
This is a belated fix to #81240 (see the latest comment)

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Sep 06 10:51:00 - Prow CI generated the docs preview:

https://81418--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-17-release-notes.html

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2024

@jherrman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jherrman
Copy link
Contributor Author

jherrman commented Sep 6, 2024

/label merge-request-needed

@openshift-ci
Copy link

openshift-ci bot commented Sep 6, 2024

@jherrman: The label(s) /label merge-request-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label merge-request-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jherrman
Copy link
Contributor Author

jherrman commented Sep 6, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 6, 2024
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.17 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 6, 2024
@bscott-rh bscott-rh added this to the Planned for 4.17 GA milestone Sep 6, 2024
@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 6, 2024
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh merged commit 2efba1a into openshift:enterprise-4.17 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants