Skip to content

OSSM 3.0 TP1: OSSM-6060 OSSM3 with cert-manager and istio-csr #83665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevsmit merged 1 commit into from
Nov 18, 2024
Merged

OSSM 3.0 TP1: OSSM-6060 OSSM3 with cert-manager and istio-csr #83665

stevsmit merged 1 commit into from
Nov 18, 2024

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented Oct 16, 2024 •
edited
Loading

OSSM 3.0 TP1

cert-manager and istio-csr was not required for TP 1 go live, but OSSM 3.0 is still in TP1 status so this applies to TP1.

Merge to: https://github.com/openshift/openshift-docs/tree/service-mesh-docs-main

Cherry pick: to https://github.com/openshift/openshift-docs/tree/service-mesh-docs-3.0.0tp1

This PR is part of the standalone doc set for the OpenShift Service Mesh project. Kathryn is aware that this content applies for a product that is part of a Technology Preview release. The project is seeking feedback from early adopters.

Version(s):

Technology Preview

OSSM 3.0 is moving to stand alone format is will not be cherry-picked back to OCP core branches.

Issue:
https://issues.redhat.com/browse/OSSM-6060

Engineering PR: openshift-service-mesh/sail-operator#148

Link to docs preview:

https://83665--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-cert-manager-assembly

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 16, 2024 •
edited
Loading

🤖 Mon Nov 18 16:21:17 - Prow CI generated the docs preview:

https://83665--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-cert-manager-assembly.html

@gwynnemonahan gwynnemonahan force-pushed the OSSM-6060 branch 3 times, most recently from 9dde153 to 3ccd6aa Compare October 29, 2024 22:31
nrfox
nrfox reviewed Oct 31, 2024
View reviewed changes
nrfox
nrfox reviewed Nov 1, 2024
View reviewed changes
Copy link

@nrfox nrfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor updates to the examples otherwise LGTM

@gwynnemonahan gwynnemonahan force-pushed the OSSM-6060 branch 5 times, most recently from 6abcbf7 to e8a1aba Compare November 1, 2024 20:04
nrfox
nrfox reviewed Nov 4, 2024
View reviewed changes
@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 4, 2024

Rebased AM 11/04/2024.

@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 7, 2024

Rebased Nov 7 afternoon.

pbajjuri20
pbajjuri20 approved these changes Nov 7, 2024
View reviewed changes
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed the Cert-Manager and verified the steps.

LGTM

jeana-redhat
jeana-redhat reviewed Nov 8, 2024
View reviewed changes
abhatt-rh
abhatt-rh reviewed Nov 8, 2024
View reviewed changes
abhatt-rh
abhatt-rh reviewed Nov 8, 2024
View reviewed changes
abhatt-rh
abhatt-rh reviewed Nov 8, 2024
View reviewed changes
abhatt-rh
abhatt-rh reviewed Nov 8, 2024
View reviewed changes
michaelryanpeter
michaelryanpeter reviewed Nov 8, 2024
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 13, 2024
michaelryanpeter
michaelryanpeter reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Early on in my review, I used in-place instead of in place. Based on Merriam-Webster, I believe that "in place" is the appropriate term.

I think that the readability of the docs would be greatly improved if you came up with a consistent set of terms for how you refer to the specific API objects/applications/binaries and when you are making a general reference to the product/project. The current inconsistency makes the content makes me feel like I am reading content from multiple authors.

I know that this seems like a lot of comments, but most of them are the same handful of inconsistencies repeated in slightly different ways. I think you are right next door to a very clear and unified tone in the doc.

If you have any questions, concerns, or disagreements, please hit me up on Slack.

@michaelryanpeter
Copy link
Contributor

michaelryanpeter commented Nov 13, 2024

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 13, 2024
@gwynnemonahan gwynnemonahan force-pushed the OSSM-6060 branch 2 times, most recently from 1d2d49c to b547763 Compare November 14, 2024 01:00
@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 14, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 14, 2024
@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 14, 2024

/label remove merge-review-needed

Engineering in put is needed to answer questions raised.

@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 14, 2024

Engineering input received and implemented.

@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 14, 2024

Commenting for the mere joy that all tests passed!

@gwynnemonahan gwynnemonahan force-pushed the OSSM-6060 branch 2 times, most recently from 9262219 to 16fbd3a Compare November 14, 2024 17:13
@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 14, 2024

Rebased 11/14/2024 late AM.

@gwynnemonahan
Copy link
Contributor Author

gwynnemonahan commented Nov 15, 2024

Rebased 11/15/2024 AM.

@stevsmit stevsmit added this to the Continuous Release milestone Nov 18, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 18, 2024
stevsmit
stevsmit reviewed Nov 18, 2024
View reviewed changes
install/ossm-cert-manager-assembly.adoc Outdated
include::modules/ossm-cert-manager-istio-csr-inplace-update-strategy.adoc[leveloffset=+2]

.Next steps
* xref:../install/ossm-cert-manager-assembly.adoc#installing-istio-resource_ossm-cert-manager-assembly[Install your Istio resource]
Copy link
Member

@stevsmit stevsmit Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically links to "Installing your. . ."

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2024

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 7314084 into openshift:service-mesh-docs-main Nov 18, 2024
2 checks passed
@stevsmit
Copy link
Member

stevsmit commented Nov 18, 2024

/cherry-pick service-mesh-docs-3.0.0tp1

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 18, 2024

@stevsmit: new pull request created: #85080

In response to this:

/cherry-pick service-mesh-docs-3.0.0tp1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@abhatt-rh abhatt-rh abhatt-rh left review comments

@stevsmit stevsmit stevsmit left review comments

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@lahinson lahinson lahinson left review comments

+2 more reviewers

@nrfox nrfox nrfox approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.