Skip to content

Conversation

@mramendi
Copy link
Contributor

@mramendi mramendi commented Oct 28, 2024

Version(s):

cp to pipelines-docs-1.15 and pipelines-docs-main. The PR into 1.14 is intentional as the RN does not display in main.

Issue:

RHDEVDOCS 6177

Link to docs preview:

https://84146--ocpdocs-pr.netlify.app/openshift-pipelines/latest/about/op-release-notes.html#release-notes-1-14-5_op-release-notes

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 28, 2024

🤖 Mon Apr 07 23:28:10 - Prow CI generated the docs preview:

https://84146--ocpdocs-pr.netlify.app/openshift-pipelines/latest/about/op-release-notes.html

@mramendi
Copy link
Contributor Author

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2025
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2025
@mramendi
Copy link
Contributor Author

mramendi commented Apr 3, 2025

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 3, 2025
@mramendi
Copy link
Contributor Author

mramendi commented Apr 4, 2025

The PR was brought back into scope as maintenance support now exists for Pipelines 1.14

@mramendi
Copy link
Contributor Author

mramendi commented Apr 4, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 4, 2025
@aspauldi
Copy link

aspauldi commented Apr 4, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 4, 2025
Copy link

@aspauldi aspauldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few teeny suggestions that you can use or not! Thanks.


* Before this update, when you configured {tekton-chains} to disable storing OCI artifacts by setting an empty `artifacts.oci.storage` value in the `TektonConfig` CR, the configuration did not work and {tekton-chains} attempted to store the artifacts and logged a failure in the `chains.tekton.dev/signed` annotation. With this update, when you set an empty `artifacts.oci.storage` value in the `TektonConfig` CR, {tekton-chains} does not attempt to store OCI artifacts.

* Before this update, when you used workspace information, such as `$(workspaces.source.path)`, in a pipeline or task, but did not define a workspace, {pipelines-shortname} did not report an error. With this update, in this case {pipelines-shortname} reports an error and does not run the pipeline or task.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Before this update, when you used workspace information, such as `$(workspaces.source.path)`, in a pipeline or task, but did not define a workspace, {pipelines-shortname} did not report an error. With this update, in this case {pipelines-shortname} reports an error and does not run the pipeline or task.
* Previously when you used workspace information, such as `$(workspaces.source.path)`, in a pipeline or task without defining a workspace, {pipelines-shortname} did not report an error. {pipelines-shortname} now reports an error in this case and does not run the pipeline or task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the styling is the boilerplate always used in this product, but I'm changing what I can.

@mramendi mramendi force-pushed the RHDEVDOCS-6177-1.14 branch from 22594a2 to 3b44a15 Compare April 7, 2025 23:03
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2025

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aspauldi
Copy link

aspauldi commented Apr 8, 2025

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 8, 2025
@mramendi
Copy link
Contributor Author

mramendi commented Apr 9, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 9, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 9, 2025
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm merging

@xenolinux xenolinux merged commit 0ea383d into openshift:pipelines-docs-1.14 Apr 9, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 9, 2025
@xenolinux xenolinux added this to the Continuous Release milestone Apr 9, 2025
@xenolinux
Copy link
Contributor

/cherrypick pipelines-docs-1.15

@xenolinux
Copy link
Contributor

/cherrypick pipelines-docs-main

@openshift-cherrypick-robot

@xenolinux: new pull request created: #91904

In response to this:

/cherrypick pipelines-docs-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@xenolinux: new pull request created: #91905

In response to this:

/cherrypick pipelines-docs-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants