-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS 6177 RN Pipelines 1.14.5 - undefined workspace info causes error now #84146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS 6177 RN Pipelines 1.14.5 - undefined workspace info causes error now #84146
Conversation
|
🤖 Mon Apr 07 23:28:10 - Prow CI generated the docs preview: https://84146--ocpdocs-pr.netlify.app/openshift-pipelines/latest/about/op-release-notes.html |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
/remove-lifecycle rotten |
|
The PR was brought back into scope as maintenance support now exists for Pipelines 1.14 |
|
/label peer-review-needed |
|
/label peer-review-in-progress |
aspauldi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few teeny suggestions that you can use or not! Thanks.
modules/op-release-notes-1-14.adoc
Outdated
|
|
||
| * Before this update, when you configured {tekton-chains} to disable storing OCI artifacts by setting an empty `artifacts.oci.storage` value in the `TektonConfig` CR, the configuration did not work and {tekton-chains} attempted to store the artifacts and logged a failure in the `chains.tekton.dev/signed` annotation. With this update, when you set an empty `artifacts.oci.storage` value in the `TektonConfig` CR, {tekton-chains} does not attempt to store OCI artifacts. | ||
|
|
||
| * Before this update, when you used workspace information, such as `$(workspaces.source.path)`, in a pipeline or task, but did not define a workspace, {pipelines-shortname} did not report an error. With this update, in this case {pipelines-shortname} reports an error and does not run the pipeline or task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Before this update, when you used workspace information, such as `$(workspaces.source.path)`, in a pipeline or task, but did not define a workspace, {pipelines-shortname} did not report an error. With this update, in this case {pipelines-shortname} reports an error and does not run the pipeline or task. | |
| * Previously when you used workspace information, such as `$(workspaces.source.path)`, in a pipeline or task without defining a workspace, {pipelines-shortname} did not report an error. {pipelines-shortname} now reports an error in this case and does not run the pipeline or task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the styling is the boilerplate always used in this product, but I'm changing what I can.
22594a2 to
3b44a15
Compare
|
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/remove-label peer-review-in-progress |
|
/label merge-review-needed |
xenolinux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm merging
|
/cherrypick pipelines-docs-1.15 |
|
/cherrypick pipelines-docs-main |
|
@xenolinux: new pull request created: #91904 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: new pull request created: #91905 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
cp to pipelines-docs-1.15 and pipelines-docs-main. The PR into 1.14 is intentional as the RN does not display in main.
Issue:
RHDEVDOCS 6177
Link to docs preview:
https://84146--ocpdocs-pr.netlify.app/openshift-pipelines/latest/about/op-release-notes.html#release-notes-1-14-5_op-release-notes
QE review:
Additional information: