Skip to content

[enterprise-4.14] OCPBUGS-31413: Remove mention of PtpConfigSlaveCvl.yaml from docs #85631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

[enterprise-4.14] OCPBUGS-31413: Remove mention of PtpConfigSlaveCvl.yaml from docs #85631

merged 1 commit into from
Dec 5, 2024

Conversation

@amolnar-gh
Copy link
Contributor

@amolnar-gh amolnar-gh commented Nov 29, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2024

@amolnar-rh: This pull request references Jira Issue OCPBUGS-31413, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OCPBUGS-31413

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
PR for main: #85629

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 29, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 29, 2024 •
edited
Loading

🤖 Fri Nov 29 14:38:43 - Prow CI generated the docs preview:

https://85631--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/ztp_far_edge/ztp-advanced-policy-config.html

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2024
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2024

@amolnar-rh: This pull request references Jira Issue OCPBUGS-31413, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OCPBUGS-31413

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
PR for main: #85629

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2024

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

aneeshkp
aneeshkp approved these changes Dec 3, 2024
View reviewed changes
Copy link

@aneeshkp aneeshkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@Bonnie-Block
Copy link

Bonnie-Block commented Dec 3, 2024

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2024

@Bonnie-Block: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amolnar-gh
Copy link
Contributor Author

amolnar-gh commented Dec 4, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 4, 2024
@bscott-rh bscott-rh added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 4, 2024
@bscott-rh bscott-rh self-assigned this Dec 4, 2024
@bscott-rh bscott-rh removed the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 4, 2024
bscott-rh
bscott-rh approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review LGTM

@bscott-rh bscott-rh added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.14 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 4, 2024
@amolnar-gh
Copy link
Contributor Author

amolnar-gh commented Dec 5, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 5, 2024
@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 5, 2024
@skopacz1 skopacz1 added this to the Continuous Release milestone Dec 5, 2024
skopacz1
skopacz1 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skopacz1 skopacz1 merged commit 186d771 into openshift:enterprise-4.14 Dec 5, 2024
2 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2024

@amolnar-rh: Jira Issue OCPBUGS-31413 is in an unrecognized state (Release Pending) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.14

Issue: https://issues.redhat.com/browse/OCPBUGS-31413

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
PR for main: #85629

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bscott-rh bscott-rh bscott-rh approved these changes

@skopacz1 skopacz1 skopacz1 approved these changes

+1 more reviewer

@aneeshkp aneeshkp aneeshkp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aneeshkp aneeshkp

@bscott-rh bscott-rh

Labels

branch/enterprise-4.14 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@amolnar-gh @openshift-ci-robot @ocpdocs-previewbot @Bonnie-Block @aneeshkp @bscott-rh @skopacz1