Skip to content

[OSDOCS 12593]:New-add-machine-pool-Win-LI to ROSA HCP docs. #87634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AedinC wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[OSDOCS 12593]:New-add-machine-pool-Win-LI to ROSA HCP docs. #87634

AedinC wants to merge 1 commit into from

Conversation

@AedinC
Copy link
Contributor

@AedinC AedinC commented Jan 27, 2025 •
edited
Loading

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/OSDOCS-12593

Link to docs preview:

Peer review:

  • Peer reviewer has approved this change.

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 27, 2025
aireilly
aireilly reviewed Jan 27, 2025
View reviewed changes
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 27, 2025 •
edited
Loading

🤖 Wed Dec 03 09:09:12 - Prow CI generated the docs preview:

https://87634--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_cluster_admin/osd_nodes/osd-managing-worker-nodes.html
https://87634--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html
https://87634--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_release_notes/rosa-release-notes.html
https://87634--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_cluster_admin/rosa_nodes/rosa-managing-worker-nodes.html
https://87634--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_release_notes/rosa-release-notes.html

@AedinC AedinC changed the title OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. [WIP]OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. Jan 27, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 2 times, most recently from 1ad928d to 005fba0 Compare January 28, 2025 15:25
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 005fba0 to 5694f45 Compare January 28, 2025 16:06
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 4 times, most recently from f6754f0 to db8df98 Compare February 6, 2025 11:20
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Feb 6, 2025
View reviewed changes
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from db8df98 to 1fe8c6f Compare February 7, 2025 08:38
@AedinC
Copy link
Contributor Author

AedinC commented Feb 7, 2025

@andreadecorte Can you please review this when you get a chance? Many thanks.

@AedinC
Copy link
Contributor Author

AedinC commented Feb 11, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 11, 2025
@adellape adellape self-assigned this Feb 11, 2025
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 11, 2025
@adellape adellape added this to the Planned for 4.18 GA milestone Feb 11, 2025
adellape
adellape reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 11, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 1fe8c6f to 6f61720 Compare February 12, 2025 11:54
@AedinC AedinC changed the title [WIP]OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. Feb 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2025
@kalexand-rh kalexand-rh removed this from the OCP 4.18 GA milestone Feb 24, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from a7e1613 to a079242 Compare November 20, 2025 10:21
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
fmcdonal
fmcdonal reviewed Nov 20, 2025
View reviewed changes
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from a079242 to 9a32cc7 Compare November 20, 2025 12:16
@fmcdonal
Copy link
Contributor

fmcdonal commented Nov 20, 2025

LGTM @AedinC with some comments and suggestions, thanks

@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from 9a32cc7 to 86009a2 Compare November 20, 2025 14:31
@fmcdonal
Copy link
Contributor

fmcdonal commented Nov 21, 2025

@AedinC you might want to update your title PR with the card number, thanks

aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
modules/creating-a-machine-pool-cli-win-li.adoc Outdated
+
[source,terminal]
----
$ rosa create machinepool --cluster=mycluster --name=mymachinepool --type=Windows --instance-type =m5zn.metal --replicas=1
Copy link

@aaraj7 aaraj7 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ rosa create machinepool --cluster=mycluster --name=mymachinepool --type=Windows --instance-type =m5zn.metal --replicas=1
$ rosa create machinepool --cluster=mycluster --name=mymachinepool --type=Windows --instance-type=m5zn.metal --replicas=1

Copy link

@aaraj7 aaraj7 Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AedinC

aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
modules/creating-a-machine-pool-cli-win-li.adoc
Desired replicas: 1
Current replicas: 1
Instance type: m5.xlarge
Image type: Windows
Copy link

@aaraj7 aaraj7 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hunterkepley Would this thing will be shown in rosa describe machinepool command in GA.

aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
modules/creating-a-machine-pool-ocm.adoc Outdated

//Commenting out until this HCP feature is available in the OCM UI
//ifdef::openshift-rosa-hcp[]
//. Optional: If you are using {VirtProductName} on a {product-title} cluster, you might want to run Windows VMs. In order to be license-compliant with Microsoft Windows in AWS, the hosts (metal EC2 instances) running these VMs must be enabled with AWS EC2 Windows License Included. To enable the machine pool for AWS Windows License Included, select the *Enable machine pool for AWS Windows License Included* checkbox.
Copy link

@aaraj7 aaraj7 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//. Optional: If you are using {VirtProductName} on a {product-title} cluster, you might want to run Windows VMs. In order to be license-compliant with Microsoft Windows in AWS, the hosts (metal EC2 instances) running these VMs must be enabled with AWS EC2 Windows License Included. To enable the machine pool for AWS Windows License Included, select the *Enable machine pool for AWS Windows License Included* checkbox.
//. Optional: If you are using {VirtProductName} on a {product-title} cluster, you might want to run Windows VMs. In order to be license-compliant with Microsoft Windows in AWS, the hosts (AMD64 bare metal EC2 instances) running these VMs must be enabled with AWS EC2 Windows License Included. To enable the machine pool for AWS Windows License Included, select the *Enable machine pool for AWS Windows License Included* checkbox.

aaraj7
aaraj7 reviewed Nov 23, 2025
View reviewed changes
modules/creating-a-machine-pool-ocm.adoc Outdated
//+
//[IMPORTANT]
//====
//You can only select this option when the host cluster is a {product-title} cluster version 4.19 and later, the instance type is bare metal EC2, and the region is `us-west-2`.
Copy link

@aaraj7 aaraj7 Nov 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//You can only select this option when the host cluster is a {product-title} cluster version 4.19 and later, the instance type is bare metal EC2, and the region is `us-west-2`.
//You can only select this option when the host cluster is a {product-title} cluster version 4.19 and later, the instance type is AMD64 bare metal EC2 instance, and the region is `us-west-2`.

Copy link

@aaraj7 aaraj7 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now in GA, every region is supported , cc: @BraeTroutman Please confirm

Copy link
Contributor

@BraeTroutman BraeTroutman Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes all non-opt-in AWS regions are supported

Copy link

@aaraj7 aaraj7 Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BraeTroutman cc: @AedinC

@AedinC AedinC changed the title OSDOCS-New-add-machine-pool-Win-LI to ROSA HCP docs. [OSDOCS 12593]:New-add-machine-pool-Win-LI to ROSA HCP docs. Nov 24, 2025
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch 2 times, most recently from e68accb to d0b0ba3 Compare November 24, 2025 14:54
@AedinC AedinC force-pushed the OSDOCS-New-add-machine-pool-Win-LI branch from d0b0ba3 to 49c3738 Compare December 3, 2025 09:01
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

@AedinC: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aireilly aireilly aireilly left review comments

+7 more reviewers

@adellape adellape adellape left review comments

@jerichokeyne jerichokeyne jerichokeyne left review comments

@hunterkepley hunterkepley hunterkepley left review comments

@BraeTroutman BraeTroutman BraeTroutman left review comments

@fmcdonal fmcdonal fmcdonal left review comments

@aaraj7 aaraj7 aaraj7 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@adellape adellape

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.