Skip to content

[enterprise-4.17] HCIDOCS-548: Cherry pick for 88413 #88666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

[enterprise-4.17] HCIDOCS-548: Cherry pick for 88413 #88666

merged 1 commit into from
Feb 17, 2025

Conversation

@johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Feb 14, 2025

This PR is a manual cherry pick for #88413. Structural change was made to 4.18, so the link uses _ipi/ rather than /ipi/.

Version(s): 4.17

Issue: https://issues.redhat.com/browse/HCIDOCS-548

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2025 •
edited by openshift-ci bot
Loading

@johnwilkins: This pull request references HCIDOCS-548 which is a valid jira issue.

In response to this:

This PR is a manual cherry pick for #88413. Structural change was made to 4.18, so the link uses _ipi/ rather than /ipi/.

Version(s): 4.17

Issue: https://issues.redhat.com/browse/HCIDOCS-548

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 14, 2025

🤖 Fri Feb 14 21:33:18 - Prow CI generated the docs preview:

https://88666--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/overview/installing-preparing.html

@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2025

@johnwilkins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@johnwilkins
Copy link
Contributor Author

johnwilkins commented Feb 14, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 14, 2025
xenolinux
xenolinux reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 17, 2025
@xenolinux
Copy link
Contributor

xenolinux commented Feb 17, 2025

Merging this PR because this is a manual cherry-pick PR.

@xenolinux xenolinux merged commit b721291 into openshift:enterprise-4.17 Feb 17, 2025
2 checks passed
@xenolinux xenolinux changed the title HCIDOCS-548: Cherry pick for 88413 [enterprise-4.17] HCIDOCS-548: Cherry pick for 88413 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.17 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnwilkins @openshift-ci-robot @ocpdocs-previewbot @xenolinux