Skip to content

OSSM-8296 [DOC] Istio mTLS Configuration Doc #89056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

OSSM-8296 [DOC] Istio mTLS Configuration Doc #89056

merged 1 commit into from
Feb 28, 2025

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Feb 24, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 24, 2025 •
edited
Loading

🤖 Fri Feb 28 10:30:31 - Prow CI generated the docs preview:

https://89056--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/install/ossm-enabling-mtls.html

dgn
dgn reviewed Feb 25, 2025
View reviewed changes
dgn
dgn approved these changes Feb 25, 2025
View reviewed changes
Copy link

@dgn dgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

sridhargaddam
sridhargaddam reviewed Feb 25, 2025
View reviewed changes
sridhargaddam
sridhargaddam reviewed Feb 25, 2025
View reviewed changes
@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Feb 27, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 27, 2025
@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 28, 2025
xenolinux
xenolinux reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice content!

Left some comments to consider; LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 28, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

shreyasiddhartha commented Feb 28, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 28, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 28, 2025
xenolinux
xenolinux reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing comments

LGTM merging

@xenolinux xenolinux merged commit 3bebafe into openshift:service-mesh-docs-main Feb 28, 2025
2 checks passed
@xenolinux
Copy link
Contributor

xenolinux commented Feb 28, 2025

/cherrypick service-mesh-docs-3.0

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 28, 2025
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 28, 2025

@xenolinux: new pull request created: #89368

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

+3 more reviewers

@FilipB FilipB FilipB approved these changes

@dgn dgn dgn approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shreyasiddhartha @ocpdocs-previewbot @xenolinux @openshift-cherrypick-robot @FilipB @dgn @sridhargaddam