Skip to content

OBSDOCS-1804: Allow loki to use virtual-host-style as an explicit co… #94299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

OBSDOCS-1804: Allow loki to use virtual-host-style as an explicit co… #94299

wants to merge 2 commits into from

Conversation

@theashiot
Copy link
Contributor

@theashiot theashiot commented Jun 5, 2025 •
edited
Loading

Version(s): 6.0+

Issue: OBSDOCS-1804

Link to docs preview: https://94299--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025

@theashiot: No Jira issue with key OBSSDOCS-1701 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 6.0+

Issue: https://issues.redhat.com/browse/OBSDOCS-1804

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 5, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 5, 2025 •
edited
Loading

🤖 Fri Jun 27 11:24:06 - Prow CI generated the docs preview:

https://94299--ocpdocs-pr.netlify.app/
https://94299--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025 •
edited by openshift-ci bot
Loading

@theashiot: No Jira issue with key OBSSDOCS-1701 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 6.0+

Issue: OBSDOCS-1804

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025

@theashiot: No Jira issue with key OBSSDOCS-1701 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 6.0+

Issue: OBSDOCS-1804

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theashiot
Copy link
Contributor Author

theashiot commented Jun 5, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025

@theashiot: No Jira issue with key OBSSDOCS-1701 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025

@theashiot: The referenced Jira(s) [OBSSDOCS-1701] could not be located, all automatically applied jira labels will be removed.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025

@theashiot: No Jira issue with key OBSSDOCS-1701 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Version(s): 6.0+

Issue: OBSDOCS-1804

Link to docs preview: https://94299--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theashiot theashiot changed the title OBSSDOCS-1701: Allow loki to use virtual-host-style as an explicit co… OBSDOCS-1804: Allow loki to use virtual-host-style as an explicit co… Jun 5, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-1804 which is a valid jira issue.

In response to this:

Version(s): 6.0+

Issue: OBSDOCS-1804

Link to docs preview: https://94299--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@theashiot
Copy link
Contributor Author

theashiot commented Jun 5, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2025 •
edited by openshift-ci bot
Loading

@theashiot: This pull request references OBSDOCS-1804 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoaoBraveCoding
JoaoBraveCoding reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is only moving the old content to a new page, no mention of virtual-host-style

@kcarmichael08 @theashiot
Merge pull request openshift#94423 from theashiot/OBSDOCS-1726-standa…
52667ba 
…lone

OBSDOCS-1726: Port the "Installing log storage" sections to 5.8 and 6…
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 26, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2025

@theashiot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@theashiot
Copy link
Contributor Author

theashiot commented Jul 2, 2025

Hi @JoaoBraveCoding i've added content about virtual-host-style, can you please review?

thanks,
ashwin

@theashiot
Copy link
Contributor Author

theashiot commented Jul 7, 2025

This is made obsolete by #95688

@theashiot theashiot closed this Jul 7, 2025
prithvipatil97
prithvipatil97 reviewed Jul 8, 2025
View reviewed changes
modules/logging-loki-storage-aws.adoc
--from-literal=access_key_id="<aws_access_key_id>" \
--from-literal=access_key_secret="<aws_access_key_secret>" \
--from-literal=region="<aws_region_of_your_bucket>"
--from-literal=force_path_style="true" # <2>
Copy link
Contributor

@prithvipatil97 prithvipatil97 Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be updated with:

 --from-literal=s3_force_path_style="true" # <2>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding left review comments

@prithvipatil97 prithvipatil97 prithvipatil97 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@theashiot @openshift-ci-robot @ocpdocs-previewbot @JoaoBraveCoding @prithvipatil97 @kcarmichael08