(ON HOLD) [OBSDOCS-1471] Logging 5.8 docs missing from 4.17 #97452
Conversation
openshift-ci
bot
added
the
size/XXL
|
🤖 Mon Sep 15 07:49:10 - Prow CI generated the docs preview: |
ochromy
force-pushed
the
OBSDOCS-1471
branch
6 times, most recently
from
6e46c2b to
04e4c50
Compare
|
/retest |
ochromy
force-pushed
the
OBSDOCS-1471
branch
7 times, most recently
from
4ce1d44 to
171df93
Compare
theashiot
left a comment
theashiot
left a comment
There was a problem hiding this comment.
Thanks, @ochromy for the wonderful work in this PR! I've added some suggestions inline. Apart from those suggestions, here are some more:
- "xref"s are visible here: https://97452--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/cluster-logging
- Change 5.9.* to 5.8.* in this chapter: https://97452--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/cluster-logging-upgrading
- Remove the include "modules/logging-delivery-tuning.adoc" from the assembly log_collection_forwarding/configuring-log-forwarding.adoc as it pertains to logging 5.9.
- Typo in the link under Additional resources section of file:///Users/amehenda/Git/openshift-docs/_preview/openshift-enterprise/OBSDOCS-1471/observability/logging/log_collection_forwarding/configuring-log-forwarding.html#logging-audit-filtering_configuring-log-forwarding
best,
ashwin
| - Name: Viewing Logging status | ||
| File: cluster-logging-cluster-status | ||
| - Name: Troubleshooting log forwarding | ||
| File: log-forwarding-troubleshooting |
There was a problem hiding this comment.
Possibly missing the following:
- Name: Troubleshooting logging alerts
File: troubleshooting-logging-alerts
- Name: Viewing the status of the Elasticsearch log store
File: cluster-logging-log-store-status
There was a problem hiding this comment.
can we create a separate panel for 5.8? And put all items(5.8 release note and etc) related to 5.8 under that link ?
Logging 6.2
Logging 6.1
Logging 6.0
Logging 5.8
| resources: | ||
| limits: | ||
| memory: 32Gi | ||
| cpu: 200m |
There was a problem hiding this comment.
the changes in this file need technical review
observability/logging/logging_release_notes/opentelemetry-data-model.adoc
Outdated
Show resolved
Hide resolved
observability/logging/logging_release_notes/upgrading/docinfo.xml
Outdated
Show resolved
Hide resolved
ochromy
force-pushed
the
OBSDOCS-1471
branch
2 times, most recently
from
e57aa1f to
c8b9073
Compare
include assemblies remove elasticsearch instances no1 fix topicmap no1 fix asciidoc no1 add loki-statement-snip fix opentelemetry attributes fix opentelemetry attributes no2 fix opentelemetry attributes no3 add logging 5.x from 4.16 topic-map fix no2 topic-map fix no3 topic-map fix no4 release note fix no1 kibana fix topic_map fix no5 add release notes add release notes no2 pr review no1 1/2 pr review no1 2/2 pr review no2 fix validation err no1
ochromy
force-pushed
the
OBSDOCS-1471
branch
from
c8b9073 to
9769413
Compare
|
@ochromy: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| .Procedure | ||
|
|
||
| To use the Log Forward API to forward audit logs to the internal Elasticsearch instance: | ||
| To use the Log Forwarding API to forward audit logs to the internal Elasticsearch instance: |
There was a problem hiding this comment.
According to https://access.redhat.com/support/policy/updates/openshift_operators. Elasticsearch-opertaor in 4.16,4.17 is for trace only. I think we needn't remove all section as elasticsearch as interal store.
|
According to https://access.redhat.com/support/policy/updates/openshift_operators. Elasticsearch-opertaor in 4.16,4.17 is for trace only. I think we needn't remove all sections as elasticsearch/kibana/curator. |
| + | ||
| [source,yaml] | ||
| ---- | ||
| $ oc edit ClusterLogging instance |
There was a problem hiding this comment.
This file is about elasticsearch, it can be removed.
|
|
||
| . Change to the `openshift-logging` project: | ||
| + | ||
| [source,terminal] |
There was a problem hiding this comment.
This file is about elasticsearch, it can be removed.
| [source,terminal] | ||
| ---- | ||
| $ oc adm must-gather --image=$(oc -n openshift-logging get deployment.apps/cluster-logging-operator -o jsonpath='{.spec.template.spec.containers[?(@.name == "cluster-logging-operator")].image}') | ||
| $ oc adm must-gather --image=quay.io/openshift/origin-cluster-logging-operator |
There was a problem hiding this comment.
Any reason we change the image to quay.io/openshift/origin-cluster-logging-operator?
briandooley
added
the
do-not-merge/hold
ochromy
changed the title
|
Closing as obsolete. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Closing as obsolete. |
6 participants
Version(s):
enterprise-4.17
Issue:
Link to docs preview:
QE review: