Skip to content

OSDOCS-14026 Adding UID and Extras to table #98295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

OSDOCS-14026 Adding UID and Extras to table #98295

merged 1 commit into from
Oct 10, 2025

Conversation

@cbippley
Copy link
Contributor

@cbippley cbippley commented Aug 29, 2025 •
edited
Loading

Version(s): 4.20+

Issue: OSDOCS-14026

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 29, 2025 •
edited
Loading

🤖 Thu Oct 09 16:07:30 - Prow CI generated the docs preview:

https://98295--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html

@cbippley cbippley force-pushed the OSDOCS-14026 branch 2 times, most recently from c223cc0 to afbd188 Compare September 2, 2025 20:04
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 2, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2025
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 3, 2025
View reviewed changes
everettraven
everettraven reviewed Sep 12, 2025
View reviewed changes
@cbippley cbippley force-pushed the OSDOCS-14026 branch 2 times, most recently from ad8d083 to 1b24dbf Compare September 16, 2025 19:21
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2025
@cbippley cbippley force-pushed the OSDOCS-14026 branch 2 times, most recently from 2b04b42 to 7f1dee9 Compare September 18, 2025 19:43
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2025
everettraven
everettraven reviewed Sep 19, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2025
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Sep 19, 2025
View reviewed changes
everettraven
everettraven reviewed Sep 19, 2025
View reviewed changes
everettraven
everettraven reviewed Sep 19, 2025
View reviewed changes
everettraven
everettraven reviewed Sep 19, 2025
View reviewed changes
everettraven
everettraven reviewed Sep 19, 2025
View reviewed changes
Copy link

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a couple minor things I noticed, this LGTM

everettraven
everettraven approved these changes Sep 29, 2025
View reviewed changes
Copy link

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
xingxingxia
xingxingxia reviewed Sep 30, 2025
View reviewed changes
xingxingxia
xingxingxia reviewed Sep 30, 2025
View reviewed changes
@xingxingxia
Copy link
Contributor

Except above minor issues, the rest LGTM

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2025

New changes are detected. LGTM label has been removed.

@cbippley
Copy link
Contributor Author

cbippley commented Oct 8, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 8, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.20 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 9, 2025
@xenolinux xenolinux added this to the Planned for 4.20 GA milestone Oct 9, 2025
xenolinux
xenolinux reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some comments to consider before the merge. Reminder to add the preview link in comment 0.

modules/external-auth-configuring.adoc Outdated
# ...
spec:
oidcProviders: <1>
type: OIDC <1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: OIDC <1>
type: OIDC # <1>

Suggestion for all call outs. https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#using-asciidoc-callouts-in-the-yaml

Comment out the callout in the YAML file to ensure that file can still be parsed as valid YAML.

@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 9, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2025

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux xenolinux merged commit 6e80837 into openshift:main Oct 10, 2025
2 checks passed
@xenolinux
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #100313

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 10, 2025
Merged
This was referenced Oct 15, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

+3 more reviewers

@xingxingxia xingxingxia xingxingxia left review comments

@everettraven everettraven everettraven approved these changes

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@everettraven everettraven

Labels

branch/enterprise-4.20 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.20 GA

Development

Successfully merging this pull request may close these issues.

7 participants

@cbippley @ocpdocs-previewbot @xingxingxia @xenolinux @openshift-cherrypick-robot @everettraven @ocpdocs-vale-bot