-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1886: Docs for Network Policies #99686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@eromanova97: This pull request references OBSDOCS-1886 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Fri Sep 26 09:50:31 - Prow CI generated the docs preview: |
6be0334 to
f516719
Compare
|
@eromanova97: This pull request references OBSDOCS-1886 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f516719 to
97777e8
Compare
97777e8 to
24ac3f9
Compare
|
@eromanova97: This pull request references OBSDOCS-1886 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
shreyasiddhartha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Eliska!
Left 2 suggestions for you. Overall LGTM! ❤️
Peer review done.
24ac3f9 to
54171c1
Compare
|
@eromanova97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This issue has been merged as part of this PR: #96782 |
Version(s): 4.12 +
Issue: https://issues.redhat.com/browse/OBSDOCS-1886
Link to docs preview: https://99686--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-troubleshooting.html#troubleshoot-network-policies_otel-troubleshoot
QE review:
Additional information: