<oo-admin-check-sources.py> Bug 1023371, Bug 1024532 - fix logic for subscription/version detection, add and refine "fail-then-bail" workflow #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subscription/version detection, add and refine "fail-then-bail" workflow https://bugzilla.redhat.com/show_bug.cgi?id=1023371 https://bugzilla.redhat.com/show_bug.cgi?id=1024532 This improves subscription/version detection to address BZ 1023371, addresses the missing repo error from BZ 1024532 and adds logic to stop after a class of issue (missing repo, disabled repo, etc.) has been detected. Also: * set the exit code to `0` if no problems are detected, `1` otherwise * improve subscription type and version detection * moved yum-plugin-priorities check to be right before the dependent checks * repaired ose-2.0 repoids in `repo_db` - they seem to have changed at some point in the past week? Work remains - the fail-then-bail workflow applies to the `--fix` option as well, which might not be what we want
dobbymoodge
added a commit
that referenced
this pull request
Oct 30, 2013
<oo-admin-check-sources.py> Bug 1023371, Bug 1024532 - fix logic for subscription/version detection, add and refine "fail-then-bail" workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1023371
https://bugzilla.redhat.com/show_bug.cgi?id=1024532
This improves subscription/version detection to address BZ 1023371,
addresses the missing repo error from BZ 1024532 and adds logic to
stop after a class of issue (missing repo, disabled repo, etc.) has
been detected.
Also:
0if no problems are detected,1otherwiserepo_db- they seem to have changed atsome point in the past week?
Work remains - the fail-then-bail workflow applies to the
--fixoption as well, which might not be what we want