<oo-admin-check-sources.py> Bug 1026793, handle RepoError exceptions #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1026793 Wrapped the `yum-plugin-priorities` check in try/except and added new exception for "showstopper" errors. Most of the `RepoError` exceptions that can bubble out of the yum API are unrecoverable. There are probably other scenarios that can raise `RepoErrors` that aren't being handled, but the changes to `OpenShiftAdminCheckSources.main` allow us to gracefully exit for any future showstoppers we might run across
dobbymoodge
added a commit
that referenced
this pull request
Nov 5, 2013
<oo-admin-check-sources.py> Bug 1026793, handle RepoError exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1026793
Wrapped the
yum-plugin-prioritiescheck in try/except and added newexception for "showstopper" errors. Most of the
RepoErrorexceptionsthat can bubble out of the yum API are unrecoverable.
There are probably other scenarios that can raise
RepoErrorsthataren't being handled, but the changes to
OpenShiftAdminCheckSources.mainallow us to gracefully exit for anyfuture showstoppers we might run across