<check-sources> Bug 1028612, fix excludes list building logic, RHN code #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1028612 List `need_exclude` in `set_excludes` wasn't being built properly, it failed to filter by repos which already had excludes set. Added `_excludes_needed` helper function to build this list. `set_save_repo_attr` in `OpenShiftCheckSources` didn't handle writing configs from iterables for RHN correctly. Added simple logic to munge `value` variable if it's iterable Also included several spelling, formatting and minor refactors from code review with Miciah.
dobbymoodge
added a commit
that referenced
this pull request
Nov 11, 2013
<check-sources> Bug 1028612, fix excludes list building logic, RHN code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1028612
List
need_excludeinset_excludeswasn't being built properly, itfailed to filter by repos which already had excludes set. Added
_excludes_neededhelper function to build this list.set_save_repo_attrinOpenShiftCheckSourcesdidn't handle writingconfigs from iterables for RHN correctly. Added simple logic to munge
valuevariable if it's iterableAlso included several spelling, formatting and minor refactors from
code review with Miciah.