[JBIDE-21626] Add ImageStreamImport Capability #118
Conversation
|
looking... |
| } | ||
|
|
||
| @Override | ||
| public DockerImageURI getDockerImageRepositorySpec() { |
There was a problem hiding this comment.
why not call this #getDockerImageURI to match what you get back when you call it?
There was a problem hiding this comment.
was trying to explicitly distinguish it being in the spec section. The other is actually depricated i blieve
jcantrill
force-pushed
the
jbide_21626_pod_not_created
branch
from
96d5992 to
65d443a
Compare
|
|
||
| DockerImageURI getDockerImageRepositorySpec(); | ||
|
|
||
| void setDockerImageRepositorySpec(String imageUri); |
There was a problem hiding this comment.
is this replacing deprecated #setDockerImageRepository? What is the difference? having this explained in javadoc would help a lot
jcantrill
force-pushed
the
jbide_21626_pod_not_created
branch
2 times, most recently
from
927b984 to
026342f
Compare
jcantrill
force-pushed
the
jbide_21626_pod_not_created
branch
from
026342f to
b2d6786
Compare
|
Evaluated for javaclient test up to b2d6786 |
|
Java Client Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test-openshift-restclient-java/78/) |
|
[merge] |
|
Java Client Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge-openshift-restclient-java/73/) |
|
Evaluated for javaclient merge up to b2d6786 |
3 participants
This PR adds support for ImageStreamImport to fix the referenced issue. It allows image metadata to be retrieved via openshift without having a connection to a docker daemon
cc @adietish @fbricon
[test]