[release-4.21] Handle missing RelatedProperties in TransferProtocolType detection

[jacob-anders]

Some BMCs (e.g. Cisco C845A M8 with Redfish Base.1.18.1) return ActionParameterMissing without RelatedProperties, only providing the missing parameter name in MessageArgs. The is_transfer_protocol_required method now checks MessageArgs as a fallback, enabling the automatic retry with TransferProtocolType.

Change-Id: I1dc23853099533817b74a8a47767ff52dc6e99e2

Assisted-By: Claude Code Sonnet 4.6
(cherry picked from commit c161b3a)

[jacob-anders]

/retest

[openshift-ci-robot]

@jacob-anders: This pull request references Jira Issue OCPBUGS-82294, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-82117 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
• expected dependent Jira Issue OCPBUGS-82117 to target a version in 4.22.0, but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Some BMCs (e.g. Cisco C845A M8 with Redfish Base.1.18.1) return ActionParameterMissing without RelatedProperties, only providing the missing parameter name in MessageArgs. The is_transfer_protocol_required method now checks MessageArgs as a fallback, enabling the automatic retry with TransferProtocolType.

Change-Id: I1dc23853099533817b74a8a47767ff52dc6e99e2

Assisted-By: Claude Code Sonnet 4.6
(cherry picked from commit c161b3a)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@jacob-anders: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hroyrh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iurygregory, jacob-anders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [iurygregory]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jacob-anders: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Some BMCs (e.g. Cisco C845A M8 with Redfish Base.1.18.1) return ActionParameterMissing without RelatedProperties, only providing the missing parameter name in MessageArgs. The is_transfer_protocol_required method now checks MessageArgs as a fallback, enabling the automatic retry with TransferProtocolType.

Change-Id: I1dc23853099533817b74a8a47767ff52dc6e99e2

Assisted-By: Claude Code Sonnet 4.6
(cherry picked from commit c161b3a)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jacob-anders]

/jira refresh

[openshift-ci-robot]

@jacob-anders: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.