New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1969902: resolver: remove legacy support for fallback parsing of CSVs #135
Conversation
When no APIs or properties are present on bundles, the resolver currently falls back to a legacy mode where that information is parsed from CSVs present in the index. This legacy fallback method causes the resolver to incorrectly identify multiple heads for a channel when: a) The index contains CSVs only on channel head bundles, and b) A package contains two channels, where one channel contains the head of the other channel and there is at least one other node between these channel head nodes in that channel. c) The bundles have no properties, provided APIs, or required APIs Conditions a) and b) are extremely prevalent, so this bug will often be encountered whenever c) itself is true. This commit removes support for the legacy CSV parsing fallback, which means that only first class fields in the GRPC API will be used during resolutions. Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: 7fa42934ea0ce5a5f4c589767ce88b8fac7f6c68
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@joelanford: This pull request references Bugzilla bug 1969902, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@joelanford: This pull request references Bugzilla bug 1969902, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.8 |
@joelanford: once the present PR merges, I will cherry-pick it on top of release-4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@joelanford: All pull requests linked via external trackers have merged: Bugzilla bug 1969902 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@joelanford: #135 failed to apply on top of branch "release-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@joelanford: #135 failed to apply on top of branch "release-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* add storage spec to scorecard config (cherry picked from commit e245efd8031e64958764253d6411e6d186911298) * Run make generate * Add godocs Co-authored-by: jmccormick2001 <jemccorm@redhat.com> Upstream-repository: api Upstream-commit: da186270e3db3fed9cc1b1d36708114e683c5308
When no APIs or properties are present on bundles, the resolver
currently falls back to a legacy mode where that information is parsed
from CSVs present in the index.
This legacy fallback method causes the resolver to incorrectly identify
multiple heads for a channel when:
a) The index contains CSVs only on channel head bundles, and
b) A package contains two channels, where one channel contains the head
of the other channel and there is at least one other node between
these channel head nodes in that channel.
c) The bundles have no properties, provided APIs, or required APIs
Conditions a) and b) are extremely prevalent, so this bug will often be
encountered whenever c) itself is true.
This commit removes support for the legacy CSV parsing fallback, which
means that only first class fields in the GRPC API will be used during
resolutions.
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 7fa42934ea0ce5a5f4c589767ce88b8fac7f6c68