Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1932139: Ensure cross-compiled opm binaries produce non-empty version information #157

Conversation

timflannagan
Copy link
Contributor

Update the root Makefile and ensure the darwin/window cross-compiled opm
binaries produce non-empty git information when running opm version.

Before, the first --ldflag value, which contained the git versioning
information was being overriden by the second --ldflag value.

…n information

Update the root Makefile and ensure the darwin/window cross-compiled opm
binaries produce non-empty git information when running `opm version`.

Before, the first --ldflag value, which contained the git versioning
information was being overriden by the second --ldflag value.
@openshift-ci openshift-ci bot requested review from awgreene and exdx August 4, 2021 20:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2021
@timflannagan timflannagan changed the title Makefile: Ensure cross-compiled opm binaries produce non-empty version information Bug 1932139: Ensure cross-compiled opm binaries produce non-empty version information Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@timflannagan: This pull request references Bugzilla bug 1932139, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1932139: Ensure cross-compiled opm binaries produce non-empty version information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 4, 2021
@timflannagan
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 4, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

@timflannagan: This pull request references Bugzilla bug 1932139, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor Author

Going to play around with the image that gets spit out to verify those changes work outside of my local environment.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2021
@awgreene
Copy link
Contributor

awgreene commented Aug 4, 2021

Looks fine provided that the binary outputs the correct version. It would be nice to include a test that prevents regressions.
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [awgreene,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@njhale
Copy link
Contributor

njhale commented Aug 12, 2021

/retest

@timflannagan
Copy link
Contributor Author

/retest
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2021
@davegord
Copy link

/retest

@timflannagan
Copy link
Contributor Author

These changes only touch the linker options provided to the various OLM binaries.

/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-upgrade

In response to this:

These changes only touch the linker options provided to the various OLM binaries.

/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021
@timflannagan
Copy link
Contributor Author

These changes only touch the linker options provided to the various OLM binaries.

/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-olm, ci/prow/e2e-gcp

In response to this:

These changes only touch the linker options provided to the various OLM binaries.

/override ci/prow/e2e-gcp
/override ci/prow/e2e-aws-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6ee2f33 into openshift:master Aug 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@timflannagan: All pull requests linked via external trackers have merged:

Bugzilla bug 1932139 has been moved to the MODIFIED state.

In response to this:

Bug 1932139: Ensure cross-compiled opm binaries produce non-empty version information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants