New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1932139: Ensure cross-compiled opm binaries produce non-empty version information #157
Bug 1932139: Ensure cross-compiled opm binaries produce non-empty version information #157
Conversation
…n information Update the root Makefile and ensure the darwin/window cross-compiled opm binaries produce non-empty git information when running `opm version`. Before, the first --ldflag value, which contained the git versioning information was being overriden by the second --ldflag value.
@timflannagan: This pull request references Bugzilla bug 1932139, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@timflannagan: This pull request references Bugzilla bug 1932139, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Going to play around with the image that gets spit out to verify those changes work outside of my local environment. /hold |
Looks fine provided that the binary outputs the correct version. It would be nice to include a test that prevents regressions. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awgreene, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
/retest |
These changes only touch the linker options provided to the various OLM binaries. /override ci/prow/e2e-upgrade |
@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
These changes only touch the linker options provided to the various OLM binaries. /override ci/prow/e2e-gcp |
@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-aws-olm, ci/prow/e2e-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@timflannagan: All pull requests linked via external trackers have merged: Bugzilla bug 1932139 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the root Makefile and ensure the darwin/window cross-compiled opm
binaries produce non-empty git information when running
opm version
.Before, the first --ldflag value, which contained the git versioning
information was being overriden by the second --ldflag value.