Bug 2000144: Mark GetBundleForChannel as deprecated and trim its response. #179

benluddy · 2021-09-01T14:04:48Z

The RPC api.Registry/GetBundleForChannel is consumed only by
package-server and by declarative index conversion. Neither reads any
field other than CsvName and CsvJson. The package-server generates one
call to this RPC per channel per package per catalog and is
responsible for needlessly large CPU utilization and resident set
sizes on registry pods. Removing the additional per-request processing
and database queries that populate unused fields makes the registry
server better able to absorb the bursty load from package-server.

The RPC api.Registry/GetBundleForChannel is consumed only by package-server and by declarative index conversion. Neither reads any field other than CsvName and CsvJson. The package-server generates one call to this RPC per channel per package per catalog and is responsible for needlessly large CPU utilization and resident set sizes on registry pods. Removing the additional per-request processing and database queries that populate unused fields makes the registry server better able to absorb the bursty load from package-server. Upstream-repository: operator-registry Upstream-commit: 86907e18e912ee4c4cce76a6f6d6c1f518d423e3

openshift-ci · 2021-09-01T14:04:52Z

@benluddy: This pull request references Bugzilla bug 2000144, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2000144: Mark GetBundleForChannel as deprecated and trim its response.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-01T14:05:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [benluddy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

benluddy · 2021-09-01T14:05:40Z

/bugzilla refresh

openshift-ci · 2021-09-01T14:05:47Z

@benluddy: This pull request references Bugzilla bug 2000144, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2021-09-01T14:07:31Z

/lgtm

benluddy · 2021-09-01T14:36:43Z

/retest

benluddy · 2021-09-01T15:24:52Z

/retest

openshift-bot · 2021-09-01T16:10:15Z

/retest-required