Bug 1982737: Make malformed CSV fail nicely (#2673)

[perdasilva]

• Modified bundle unpacking to fail installPlan with a nice message if
  after unbundling csv manifests APIVersion or Kind are blank.

• Adds FatalError type to return to checked when syncing install plans
  to see if the error causing issues is fatal or should cause the
  IP to be transitioned to failed state.

• Makes installPlan fail with a nicer more user friendly message than
  the current difficult to understand message regarding serviceAccounts.

• Adds tests using internal magic-catalog library to confirm that unpacking
  fails when APIVersion is blank.

Signed-off-by: Noah Sapse nsapse@redhat.com

Co-authored-by: Noah Sapse nsapse@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 3002cf79ce867e32d30d2190df642eaa7f449294

[openshift-ci]

@perdasilva: This pull request references Bugzilla bug 1982737, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1982737: Make malformed CSV fail nicely (#2673)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[perdasilva]

/bugzilla refresh

[perdasilva]

/bugzilla refresh

[openshift-ci]

@perdasilva: This pull request references Bugzilla bug 1982737, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[perdasilva]

/bugzilla refresh

[openshift-ci]

@perdasilva: This pull request references Bugzilla bug 1982737, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

/retest-required

[perdasilva]

/retest

[perdasilva]

/retest

[jianzhangbjz]

/bugzilla refresh

[openshift-ci]

@jianzhangbjz: This pull request references Bugzilla bug 1982737, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (kuiwang@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jianzhangbjz]

/cc @kuiwang02

[kuiwang02]

/bugzilla refresh

[openshift-ci]

@kuiwang02: This pull request references Bugzilla bug 1982737, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.11.0) matches configured target release for branch (4.11.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @kuiwang02

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[perdasilva]

/retest

[openshift-ci]

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [perdasilva,timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@perdasilva: All pull requests linked via external trackers have merged:

• openshift/operator-framework-olm#307

Bugzilla bug 1982737 has been moved to the MODIFIED state.

In response to this:

Bug 1982737: Make malformed CSV fail nicely (#2673)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.