Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-7910: Sort channels in lexicographical order in Packagemanifestst (#2925) #476

Merged
merged 1 commit into from Mar 28, 2023
Merged

OCPBUGS-7910: Sort channels in lexicographical order in Packagemanifestst (#2925) #476

merged 1 commit into from Mar 28, 2023

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Mar 24, 2023

See operator-framework/operator-registry#1069 for more details

Signed-off-by: Anik anikbhattacharya93@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

@anik120
OCPBUGS-7910: Sort channels in lexicographical order in Packagemanife…
4d388fa 
…st (#2925)

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <anikbhattacharya93@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 24, 2023
@openshift-ci-robot
Copy link

@anik120: This pull request references Jira Issue OCPBUGS-7910, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

See operator-framework/operator-registry#1069 for more details

Signed-off-by: Anik anikbhattacharya93@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@anik120
Copy link
Contributor Author

anik120 commented Mar 27, 2023

/retest

@tmshort
Copy link
Contributor

tmshort commented Mar 27, 2023

This doesn't need to be upstreamed first?

@dtfranz
Copy link
Contributor

dtfranz commented Mar 27, 2023

This doesn't need to be upstreamed first?

Looks like it was, you can find the commit here.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6ca5476 and 2 for PR HEAD 4d388fa in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2023

@anik120: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit edd42aa into openshift:master Mar 28, 2023
12 checks passed
@openshift-ci-robot
Copy link

@anik120: Jira Issue OCPBUGS-7910: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7910 has been moved to the MODIFIED state.

In response to this:

See operator-framework/operator-registry#1069 for more details

Signed-off-by: Anik anikbhattacharya93@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Contributor

/lgtm
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@perdasilva perdasilva Awaiting requested review from perdasilva

Assignees

@dtfranz dtfranz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@anik120 @openshift-ci-robot @tmshort @dtfranz @jianzhangbjz @openshift-merge-robot